feat: Support for Windows.Data.Xml.Dom APIs #3070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Will add some simple unit tests. |
7 tasks
|
@jeromelaban Should I create a new section in PackageDiffIgnore? What would be the base version for it? |
|
Yes you can. Use a section similar to this one: https://github.com/unoplatform/uno/pull/3044/files#diff-49d44d5b2511b8a0bd889bc14a811169R809
|
MartinZikmund
force-pushed
the
dev/mazi/xml
branch
from
b510879 to
19607ee
Compare
|
Thanks Martin! |
|
I will use it in my Live Tile implementation :) |
jeromelaban
approved these changes
May 6, 2020
MartinZikmund
added
the
ready-to-merge
davidjohnoliver
approved these changes
May 6, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| private string GetTestXml() | ||
| { | ||
| using var stream = typeof(Given_XmlDocument).Assembly.GetManifestResourceStream("Uno.UI.Tests.Windows_Data_Xml.DomTests.basictest.xml"); | ||
| using var streamReader = new StreamReader(stream); |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #3069
PR Type
What kind of change does this PR introduce?
What is the current behavior?
APIs not supported.
What is the new behavior?
All APIs which can be forwarded to
System.Xmlare implemented.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.