From c4f70244ca15f1971dc01a150adb65f2cf88d07e Mon Sep 17 00:00:00 2001
From: Ajit Mehrotra <ajit@lime-technology.com>
Date: Mon, 30 Mar 2026 16:49:29 -0400
Subject: [PATCH 1/2] fix(onboarding): reload after https hostname apply

- Purpose: move the unavoidable HTTPS certificate interruption to immediately after a successful hostname change in onboarding
- Before: users applied settings, advanced normally, and only hit the cert warning later when leaving onboarding for the dashboard
- Problem: the interruption happened at the wrong moment, which made the flow feel broken and could leave users re-running apply after refresh
- Change: when onboarding successfully renames the server during an HTTPS session, the Summary result confirmation now advances to NEXT_STEPS first, then reloads
- How: arm a reload flag only after a successful HTTPS hostname change, consume it when the result dialog is confirmed, await step advancement, then reload and cover the flow with a regression test
---
 .../Onboarding/OnboardingSummaryStep.test.ts  | 28 +++++++++++++++++--
 .../steps/OnboardingSummaryStep.vue           | 24 +++++++++++++---
 2 files changed, 46 insertions(+), 6 deletions(-)

diff --git a/web/__test__/components/Onboarding/OnboardingSummaryStep.test.ts b/web/__test__/components/Onboarding/OnboardingSummaryStep.test.ts
index 1cb8b99d9a..43ca634fb2 100644
--- a/web/__test__/components/Onboarding/OnboardingSummaryStep.test.ts
+++ b/web/__test__/components/Onboarding/OnboardingSummaryStep.test.ts
@@ -295,7 +295,7 @@ interface SummaryVm {
   applyResultSeverity: 'success' | 'warning' | 'error';
   handleBootDriveWarningConfirm: () => Promise<void>;
   handleBootDriveWarningCancel: () => void;
-  handleApplyResultConfirm: () => void;
+  handleApplyResultConfirm: () => Promise<void>;
 }
 
 const getSummaryVm = (wrapper: ReturnType<typeof mountComponent>['wrapper']) =>
@@ -332,7 +332,7 @@ const clickButtonByText = async (
     } else if (normalizedTarget === 'cancel') {
       vm.handleBootDriveWarningCancel();
     } else if (normalizedTarget === 'ok') {
-      vm.handleApplyResultConfirm();
+      await vm.handleApplyResultConfirm();
     } else {
       expect(button).toBeTruthy();
     }
@@ -1015,6 +1015,30 @@ describe('OnboardingSummaryStep', () => {
     expect(onComplete).not.toHaveBeenCalled();
   });
 
+  it('advances to next steps before reloading after a successful HTTPS server rename', async () => {
+    draftStore.serverName = 'Newtower';
+    const protocolSpy = vi.spyOn(window.location, 'protocol', 'get').mockReturnValue('https:');
+    const reloadSpy = vi.spyOn(window.location, 'reload').mockImplementation(() => undefined);
+    const { wrapper, onComplete } = mountComponent();
+
+    await clickApply(wrapper);
+
+    expect(updateServerIdentityMock).toHaveBeenCalledWith({
+      name: 'Newtower',
+      comment: '',
+      sysModel: undefined,
+    });
+    expect(onComplete).not.toHaveBeenCalled();
+
+    await clickButtonByText(wrapper, 'OK');
+
+    expect(onComplete).toHaveBeenCalledTimes(1);
+    expect(reloadSpy).toHaveBeenCalledTimes(1);
+
+    protocolSpy.mockRestore();
+    reloadSpy.mockRestore();
+  });
+
   it('retries final identity update after transient network errors when SSH changed', async () => {
     draftStore.useSsh = true;
     draftStore.serverDescription = 'Primary host';
diff --git a/web/src/components/Onboarding/steps/OnboardingSummaryStep.vue b/web/src/components/Onboarding/steps/OnboardingSummaryStep.vue
index 86a1e89625..ddceae80f1 100644
--- a/web/src/components/Onboarding/steps/OnboardingSummaryStep.vue
+++ b/web/src/components/Onboarding/steps/OnboardingSummaryStep.vue
@@ -1,5 +1,5 @@
 <script lang="ts" setup>
-import { computed, onBeforeUnmount, onMounted, ref } from 'vue';
+import { computed, nextTick, onBeforeUnmount, onMounted, ref } from 'vue';
 import { useI18n } from 'vue-i18n';
 import { storeToRefs } from 'pinia';
 import { useMutation, useQuery } from '@vue/apollo-composable';
@@ -57,7 +57,7 @@ import {
 } from '~/composables/gql/graphql';
 
 export interface Props {
-  onComplete: () => void;
+  onComplete: () => void | Promise<void>;
   onBack?: () => void;
   showBack?: boolean;
 }
@@ -227,6 +227,7 @@ const showBootDriveWarningDialog = ref(false);
 const applyResultTitle = ref('');
 const applyResultMessage = ref('');
 const applyResultSeverity = ref<'success' | 'warning' | 'error'>('success');
+const shouldReloadAfterApplyResult = ref(false);
 const summaryT = (key: string, values?: Record<string, unknown>) =>
   t(`onboarding.summaryStep.${key}`, values ?? {});
 
@@ -316,6 +317,8 @@ const isTransientNetworkError = (error: unknown): boolean => {
 };
 
 const sleepMs = (ms: number) => new Promise<void>((resolve) => setTimeout(resolve, ms));
+const isHttpsWindow = () =>
+  typeof window !== 'undefined' && window.location.protocol.toLowerCase() === 'https:';
 
 const runWithTransientNetworkRetry = async <T,>(
   operation: () => Promise<T>,
@@ -579,6 +582,7 @@ const handleComplete = async () => {
   isProcessing.value = true;
   error.value = null;
   logs.value = []; // Clear logs
+  shouldReloadAfterApplyResult.value = false;
 
   addLog(summaryT('logs.startingConfiguration'), 'info');
   draftStore.setInternalBootApplySucceeded(false);
@@ -617,6 +621,7 @@ const handleComplete = async () => {
       ? Boolean(coreSettingsResult.value?.vars?.useSsh || false)
       : TRUSTED_DEFAULT_PROFILE.useSsh;
     const currentSysModel = baselineLoaded ? coreSettingsResult.value?.vars?.sysModel || '' : '';
+    const serverNameChanged = baselineLoaded ? targetCoreSettings.serverName !== currentName : false;
     const shouldApplyPartnerSysModel = Boolean(
       isFreshInstall.value &&
         activationSystemModel.value &&
@@ -657,6 +662,9 @@ const handleComplete = async () => {
             }),
           shouldRetryNetworkMutations
         );
+        if (serverNameChanged && isHttpsWindow()) {
+          shouldReloadAfterApplyResult.value = true;
+        }
         addLog(summaryT('logs.serverIdentityUpdated'), 'success');
       } catch (caughtError: unknown) {
         hadNonOptimisticFailures = true;
@@ -1032,9 +1040,17 @@ const handleComplete = async () => {
   }
 };
 
-const handleApplyResultConfirm = () => {
+const handleApplyResultConfirm = async () => {
   showApplyResultDialog.value = false;
-  props.onComplete();
+  await Promise.resolve(props.onComplete());
+
+  if (!shouldReloadAfterApplyResult.value) {
+    return;
+  }
+
+  shouldReloadAfterApplyResult.value = false;
+  await nextTick();
+  window.location.reload();
 };
 
 const handleApplyClick = async () => {

From a859bf923edc26e3ca310196f6d21b9587c5267e Mon Sep 17 00:00:00 2001
From: Ajit Mehrotra <ajit@lime-technology.com>
Date: Tue, 31 Mar 2026 10:46:13 -0400
Subject: [PATCH 2/2] fix(onboarding): reload after server rename

- Purpose: simplify the post-apply onboarding handoff for hostname changes
- Before: reload was only armed when the rename succeeded and the current browser session was HTTPS
- Problem: the browser protocol check added branching we no longer want and did not match the desired product rule
- Change: any successful server-name change now arms the post-Summary reload, regardless of protocol
- How: remove the HTTPS gate, keep the advance-to-NEXT_STEPS-first behavior, and update the regression test to cover the broader rename rule
---
 .../components/Onboarding/OnboardingSummaryStep.test.ts       | 4 +---
 web/src/components/Onboarding/steps/OnboardingSummaryStep.vue | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/web/__test__/components/Onboarding/OnboardingSummaryStep.test.ts b/web/__test__/components/Onboarding/OnboardingSummaryStep.test.ts
index 43ca634fb2..32eb5cdf83 100644
--- a/web/__test__/components/Onboarding/OnboardingSummaryStep.test.ts
+++ b/web/__test__/components/Onboarding/OnboardingSummaryStep.test.ts
@@ -1015,9 +1015,8 @@ describe('OnboardingSummaryStep', () => {
     expect(onComplete).not.toHaveBeenCalled();
   });
 
-  it('advances to next steps before reloading after a successful HTTPS server rename', async () => {
+  it('advances to next steps before reloading after a successful server rename', async () => {
     draftStore.serverName = 'Newtower';
-    const protocolSpy = vi.spyOn(window.location, 'protocol', 'get').mockReturnValue('https:');
     const reloadSpy = vi.spyOn(window.location, 'reload').mockImplementation(() => undefined);
     const { wrapper, onComplete } = mountComponent();
 
@@ -1035,7 +1034,6 @@ describe('OnboardingSummaryStep', () => {
     expect(onComplete).toHaveBeenCalledTimes(1);
     expect(reloadSpy).toHaveBeenCalledTimes(1);
 
-    protocolSpy.mockRestore();
     reloadSpy.mockRestore();
   });
 
diff --git a/web/src/components/Onboarding/steps/OnboardingSummaryStep.vue b/web/src/components/Onboarding/steps/OnboardingSummaryStep.vue
index ddceae80f1..e26e6a4899 100644
--- a/web/src/components/Onboarding/steps/OnboardingSummaryStep.vue
+++ b/web/src/components/Onboarding/steps/OnboardingSummaryStep.vue
@@ -317,8 +317,6 @@ const isTransientNetworkError = (error: unknown): boolean => {
 };
 
 const sleepMs = (ms: number) => new Promise<void>((resolve) => setTimeout(resolve, ms));
-const isHttpsWindow = () =>
-  typeof window !== 'undefined' && window.location.protocol.toLowerCase() === 'https:';
 
 const runWithTransientNetworkRetry = async <T,>(
   operation: () => Promise<T>,
@@ -662,7 +660,7 @@ const handleComplete = async () => {
             }),
           shouldRetryNetworkMutations
         );
-        if (serverNameChanged && isHttpsWindow()) {
+        if (serverNameChanged) {
           shouldReloadAfterApplyResult.value = true;
         }
         addLog(summaryT('logs.serverIdentityUpdated'), 'success');