Skip to content

Conversation

@ljm42
Copy link
Member

@ljm42 ljm42 commented Nov 24, 2025

Before Submitting This PR, Please Ensure You Have Completed The Following:

  1. Are internal links to wiki documents using relative file links?
  2. Are all new documentation files lowercase, with dash separated names (ex. unraid-os.mdx)?
  3. Are all assets (images, etc), located in an assets/ subfolder next to the .md/mdx files?
  4. Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  5. Is the build succeeding?

Summary by CodeRabbit

  • Documentation
    • Updated storage pool constraints and maximum pool limits in system documentation.
    • Clarified storage device specifications across licensing tiers with enhanced footnotes.
    • Added guidance for configuring and optimizing multiple cache pools.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 24, 2025

📝 Walkthrough

Walkthrough

This PR updates storage constraint documentation across three files. The maximum supported pool count is reduced from 35 to 34, with corresponding updates to license tiers in the licensing FAQ. Footnotes are added to clarify storage device definitions, and usage guidance is expanded in the cache pools documentation.

Changes

Cohort / File(s) Summary
Pool Limits Update
docs/unraid-os/release-notes/7.0.0.md, docs/unraid-os/using-unraid-to/manage-storage/cache-pools.mdx
Maximum pool count reduced from 35 to 34 in release notes constraints section and cache pools documentation. Common use cases guidance expanded with optimization and workload isolation bullets.
Licensing FAQ Clarification
docs/unraid-os/troubleshooting/licensing-faq.mdx
Table header renamed to "Total Attached Storage Devices". License tier values updated: Starter remains "Up to 6" (with parity note), Unleashed/Lifetime changed from "Up to 35" to "Up to 34". Footnotes added defining "attached storage" and "unlimited" constraints with hardware/OS examples.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify factual accuracy of storage device count changes across all three documents
  • Check footnote formatting and markdown syntax in licensing FAQ (MD033 blocks and superscript references)
  • Confirm consistency of "35 to 34" changes across release notes and cache pools files

Possibly related PRs

Poem

🐰 Pools now cap at thirty-four,
Not thirty-five as before!
With footnotes clear, the limits shine,
Through docs refined, line by line.
Storage truths in proper prose—
Documentation grows and grows! 📚✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is a checklist template with no added context about the actual changes made in this PR. Provide a meaningful description of the changes beyond the template checklist, such as what was updated and why (e.g., pool count limits changed from 35 to 34).
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change—clarifying device count constraints per pool across multiple documentation files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-device-counts-again

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 79b4d82 and 692e910.

📒 Files selected for processing (3)
  • docs/unraid-os/release-notes/7.0.0.md (1 hunks)
  • docs/unraid-os/troubleshooting/licensing-faq.mdx (1 hunks)
  • docs/unraid-os/using-unraid-to/manage-storage/cache-pools.mdx (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: ljm42
Repo: unraid/docs PR: 394
File: docs/unraid-os/troubleshooting/licensing-faq.mdx:135-140
Timestamp: 2025-11-24T17:26:02.645Z
Learning: As of Unraid 7.2.1, the maximum devices per pool limit for Unleashed and Lifetime licenses is 200 (increased from previous limits of 60 in 6.12 and 120 in later versions).
📚 Learning: 2025-11-24T17:26:02.645Z
Learnt from: ljm42
Repo: unraid/docs PR: 394
File: docs/unraid-os/troubleshooting/licensing-faq.mdx:135-140
Timestamp: 2025-11-24T17:26:02.645Z
Learning: As of Unraid 7.2.1, the maximum devices per pool limit for Unleashed and Lifetime licenses is 200 (increased from previous limits of 60 in 6.12 and 120 in later versions).

Applied to files:

  • docs/unraid-os/release-notes/7.0.0.md
  • docs/unraid-os/using-unraid-to/manage-storage/cache-pools.mdx
  • docs/unraid-os/troubleshooting/licensing-faq.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: deploy-preview
🔇 Additional comments (5)
docs/unraid-os/release-notes/7.0.0.md (1)

146-148: Pool constraint update is clearly stated and consistent.

The change from 35 to 34 pools is well-documented with historical context. This aligns with concurrent updates in other documentation files and serves the PR objective effectively.

docs/unraid-os/using-unraid-to/manage-storage/cache-pools.mdx (2)

304-304: Pool limits correctly updated and clearly communicated.

The update to 34 pools (from 35) is consistent with the release notes, and explicitly stating "up to 200 devices" per pool provides useful specificity that aligns with current licensing constraints.


306-311: Expanded guidance improves practical value.

Adding concrete use-case bullets (optimize performance, protect data, isolate workloads, manage flexibly) gives users better context for understanding why multiple pools matter. This complements the technical table that follows.

docs/unraid-os/troubleshooting/licensing-faq.mdx (2)

135-139: Table restructuring significantly improves clarity.

Separating "Parity-Protected Array," "Named Pools," "Devices per Pool," and "Total Attached Storage Devices" into distinct columns removes ambiguity about which limits apply where. The update from 35 to 34 pools for Unleashed/Lifetime is consistent with the release notes and system-wide constraint.


143-146: Footnotes effectively disambiguate terminology.

Adding explicit definitions for "Attached storage devices" (total drives attachable before array start, excluding USB boot device) and "Unlimited" (license vs. hardware/OS constraints) addresses likely user confusion. The examples given (VMs, unassigned devices) are practical and helpful.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

PR Preview Action v1.6.3

🚀 View preview at
https://unraid.github.io/docs/pr-preview/pr-395/

Built to branch gh-pages at 2025-11-24 20:00 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ljm42 ljm42 merged commit 8521997 into main Nov 24, 2025
3 checks passed
@ljm42 ljm42 deleted the fix-device-counts-again branch November 24, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants