Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to ease running multiple instances and some more commands for faster requests #91

Merged
merged 12 commits into from Oct 22, 2017

Conversation

@bennihepp
Copy link
Contributor

@bennihepp bennihepp commented Sep 29, 2017

I added command line options to select viewport sizes, FOV, network port and also a flag that makes Unreal exit on network failures (helping in running instances for very long times).
Moved supported view modes into FServerConfig as well.

Also added commands to enable showing and hiding of objects.

To speed up requests in general new commands for setting/getting location and rotation together and a new command for getting RGB, depth and normal image together.

Added compatibility for Python 3 in the unrealcv python library.

bennihepp added 10 commits Aug 10, 2017
…idth, height, port and FOV from the command line when starting Unreal
…rs (useful for recovery when running something long-term)
… of ExitOnFailure and added option for disabling/enabling right eye camera.
* Commands for getting and setting camera pose (location and rotation together).
* Commands for getting RGB or Normal image in NPY format.
* Commands for getting RGB, Depth and Normal image together (all in NPY format).
* Additional depth mode with depth distances to the camera plane, instead of ray distance to camera center. Mode is called "plane_depth".
@qiuwch
Copy link
Member

@qiuwch qiuwch commented Oct 13, 2017

Hi, @bennihepp:

Really sorry for the slow response. This is an awesome pull request. Thanks a lot!
I am busy with some internship projects and did not have enough time to merge it. I will finish merging it this weekend.

Benjamin Hepp added 2 commits Oct 13, 2017
* Request message is encoded as utf-8 if not already bytes object (only python 3).
* Response is returned as bytes object (only python 3). Decoding the response as utf-8 would break all the binary data transfer (i.e. png or npy data).
@qiuwch
Copy link
Member

@qiuwch qiuwch commented Oct 18, 2017

I merged the changes into the develop branch and is writing a demo notebook here (not finished).

Also add the documentation to here

Still testing some features and will merge it to master.

Sorry for the slow response and thanks again.

@qiuwch qiuwch merged commit a4abc3c into unrealcv:master Oct 22, 2017
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@bennihepp
Copy link
Contributor Author

@bennihepp bennihepp commented Oct 22, 2017

Hi @qiuwch,

thanks a lot for merging this! Now I can use the develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants