Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on TLS errors missing the IP part #180

Closed
wants to merge 1 commit into from
Closed

Fix on TLS errors missing the IP part #180

wants to merge 1 commit into from

Conversation

westor7
Copy link
Contributor

@westor7 westor7 commented Nov 3, 2021

Officially reported by delta.

Closes https://bugs.unrealircd.org/view.php?id=5993

@simplexish
Copy link
Contributor

After some light testing it seems that this patch fixes the issue.

@syzop
Copy link
Member

syzop commented Nov 5, 2021

Thanks for the report and the PR. Should be fixed now.

$client expands to the name of the client, so nick name or server name. (any $var for something with sub-items would expand to $var.name).

In this case $client.details is better which can evaluate to a number of things, depending on how much info is available. In this case it will almost always evaluate to the IP address of the user. I also changed the logging routine a bit to not show "@127.0.0.1" in this case but show it as "[127.0.0.1]" so it's clear it is (only) an IP address.

@syzop syzop closed this Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants