feat: add per-call ContentType override via CallOptions#111
Merged
Conversation
2a32ad3 to
05ca08c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional per-call options to
Data,HTML,JSON,JSONP,Text, andXML, letting callers override the responseContent-Typefor a single call without spinning up a secondRenderinstance.Closes #109.
Changes
CallOptionsstruct (withContentTypefield) accepted as a trailing variadic argument byData,JSON,JSONP,Text, andXML.HTMLOptionsgains aContentTypefield, propagated throughprepareHTMLOptions.resolveContentTypehelper centralizes the override logic.Content-Typevalue.Testing
go build ./...go vet ./...go test -race ./...TestXxxPerCallContentTypefor each of the six renderers.Additional Context
The override path intentionally bypasses charset appending so callers retain full control of the header — for example,
application/vnd.api+jsonalready implies UTF-8 and shouldn't get a duplicate charset suffix.