Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pathname strips out / #200

Closed
JSeligsohn opened this issue Feb 18, 2021 · 4 comments
Closed

Pathname strips out / #200

JSeligsohn opened this issue Feb 18, 2021 · 4 comments

Comments

@JSeligsohn
Copy link

@JSeligsohn JSeligsohn commented Feb 18, 2021

Looks like in v1.5.0, pathname no longer includes the initial / from the url. Is that intentional? A breaking change from v1.4.7?

e.g.
url: /yippee/abc
1.4.7 -> path = /yippee/abc
1.5.0 -> path = yippee/abc

@3rd-Eden
Copy link
Member

@3rd-Eden 3rd-Eden commented Feb 18, 2021

It's a bug

@lpinca
Copy link
Member

@lpinca lpinca commented Feb 18, 2021

This is the same underlying issue as #199.

@JSeligsohn
Copy link
Author

@JSeligsohn JSeligsohn commented Feb 18, 2021

Okay, good to know. I'll have to revert to 1.4.7 in the meantime.

3rd-Eden added a commit that referenced this issue Feb 18, 2021
3rd-Eden added a commit that referenced this issue Feb 18, 2021
* [fix] Fixes relative path resolving #199 #200
* [test] Additional extractProtocol tests
@3rd-Eden
Copy link
Member

@3rd-Eden 3rd-Eden commented Feb 18, 2021

Fixed in 1.5.1, thanks for reporting <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants