Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle userinfo containing the at sign #223

Merged
merged 1 commit into from Feb 13, 2022

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jan 8, 2022

Correctly handle usernames and passwords containing the at sign (@).

@lpinca
Copy link
Member Author

@lpinca lpinca commented Jan 8, 2022

cc: @3rd-Eden.

@lpinca lpinca force-pushed the fix/at-sign-handling-in-userinfo branch from cb7fecb to 2fac434 Compare Jan 8, 2022
@lpinca lpinca changed the title Use the last occurence of the at sign for userinfo Correctly handle userinfo containing the at sign Jan 8, 2022
@lpinca lpinca force-pushed the fix/at-sign-handling-in-userinfo branch from 2fac434 to 9be7ee8 Compare Jan 30, 2022
@JamieSlome
Copy link

@JamieSlome JamieSlome commented Feb 7, 2022

Just (cc)'ing myself into the thread 👍

@Swaagie Swaagie merged commit 7b0b8a6 into master Feb 13, 2022
11 checks passed
@Swaagie Swaagie deleted the fix/at-sign-handling-in-userinfo branch Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants