Skip to content

Updated Dockerfile for DGX Spark #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2025
Merged

Updated Dockerfile for DGX Spark #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Dockerfile_DGX_Spark
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM nvcr.io/nvidia/pytorch:25.09-py3

# Set CUDA environment variables
ENV CUDA_HOME=/usr/local/cuda-13.0/
ENV CUDA_HOME=/usr/local/cuda-13.0
ENV CUDA_PATH=$CUDA_HOME
ENV PATH=$CUDA_HOME/bin:$PATH
ENV LD_LIBRARY_PATH=$CUDA_HOME/lib64:$LD_LIBRARY_PATH
Expand All @@ -24,7 +24,8 @@ RUN git clone --depth=1 https://github.com/facebookresearch/xformers --recursive
cd ..

# Install unsloth and other dependencies
RUN pip install unsloth unsloth_zoo bitsandbytes==0.48.0 transformers==4.56.2 trl==0.22.2
RUN pip install --no-deps bitsandbytes==0.48.0 transformers==4.56.2 trl==0.22.2
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The addition of --no-deps to the pip install command for bitsandbytes, transformers, and trl means these packages will be installed without their declared dependencies. This can lead to runtime errors if their required dependencies are not already satisfied by the base image or explicitly installed in a previous step. It's generally safer to let pip manage dependencies unless there's a very specific reason to override this behavior, and if so, those dependencies should be explicitly handled. Consider removing --no-deps for a more robust installation, or explicitly list and install all necessary dependencies for these packages.

RUN pip install bitsandbytes==0.48.0 transformers==4.56.2 trl==0.22.2

RUN pip install unsloth unsloth_zoo

# Launch the shell
CMD ["/bin/bash"]
CMD ["/bin/bash"]