New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom keys for "active language" site payload #68

Merged
merged 2 commits into from Jul 23, 2017

Conversation

Projects
None yet
2 participants
@vlsi
Collaborator

vlsi commented Jul 22, 2017

fixes #41

@untra

This comment has been minimized.

Show comment
Hide comment
@untra

untra Jul 22, 2017

Owner

Ahh! this is done to set whatever the theme / alternate plugin thinks the active_lang should be called. Minimal mistakes expects locale, so setting

lang_vars: ['locale']

will make sure the site.locale matches site.active_lang.

I kinda don't like it because it adds another configuration option I'm not sure many people will need, but it does provide an interop mechanism with minimal mistakes and other themes that don't match polyglots standard interface.

I'd say add to the readme with a bit of documentation about it, and I'll approve. Nice work! 👍

Owner

untra commented Jul 22, 2017

Ahh! this is done to set whatever the theme / alternate plugin thinks the active_lang should be called. Minimal mistakes expects locale, so setting

lang_vars: ['locale']

will make sure the site.locale matches site.active_lang.

I kinda don't like it because it adds another configuration option I'm not sure many people will need, but it does provide an interop mechanism with minimal mistakes and other themes that don't match polyglots standard interface.

I'd say add to the readme with a bit of documentation about it, and I'll approve. Nice work! 👍

@vlsi vlsi referenced this pull request Jul 22, 2017

Merged

Fix/i18n headers #67

@untra

untra approved these changes Jul 22, 2017 edited

Awesome dude! 👍
Merge it when you're ready

@vlsi vlsi merged commit 91f9621 into untra:master Jul 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment