Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade all npm packages. #149

Merged
merged 14 commits into from Jan 2, 2023
Merged

Upgrade all npm packages. #149

merged 14 commits into from Jan 2, 2023

Conversation

smellman
Copy link
Contributor

@smellman smellman commented Jan 2, 2023

Description

Upgrade all npm packages and fixes some code to supports new maplibre-gl-style-spec.
It includes some security fixes, and update for sprite-one new release.

Type of Pull Request

  • Adding a feature
  • Fixing a bug
  • Maintaining documents
  • Others (maintenance libraries)

Verify the followings

  • Code is up-to-date with the main branch
  • No build errors after npm run build
  • No lint errors after npm run lint
  • No errors on using charites help globally
  • Make sure all the existing features working well
  • Have you added at least one unit test if you are going to add new feature?
  • Have you updated documentation?

Refer to CONTRIBUTING.MD for more details.

@smellman smellman mentioned this pull request Jan 2, 2023
Closed
@smellman
Copy link
Contributor Author

smellman commented Jan 2, 2023

16.x Windows build was failed, but I did re-run test, the build was passed.

@keichan34 keichan34 linked an issue Jan 2, 2023 that may be closed by this pull request
Announce: maplibre-gl-style-spec with a breaking change #107
Closed
keichan34
keichan34 approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@keichan34 keichan34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the rerun on the windows test. It looks like those tests aren't very stable... I'll stabilize them in the near future.

@smellman smellman merged commit 28d8789 into unvt:main Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keichan34 keichan34 keichan34 approved these changes

@yuiseki yuiseki Awaiting requested review from yuiseki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Announce: maplibre-gl-style-spec with a breaking change
2 participants
@smellman @keichan34