Support reproducible builds. #48
Conversation
Because b951f62 (from PR #6) tried to add support for this, but it is not actually being used anywhere. The standard environment variable for defining reproducible build environments is SOURCE_DATE_EPOCH, which should be used to derive the BUILD_DATE macro rather than an environment variable matching said internal macro. This is simplified even more by simply using the compiler's built-in macros for __DATE__ and __TIME__ when the file "about_scr.c" is processed by cpp. This natively supports SOURCE_DATE_EPOCH in the compiler itself.
|
Note https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=e3e8c48c4a494d9da741c1c8ea6c4c0b7c4ff934 is where the builtin macros gained support for reproducible builds. Commit b951f62 predates this, so at the time the macro would not have been able to be used. However it should have still set BUILD_DATE via:
|
|
Thank you, am thinking of maybe removing the 'build date' in a future release, which would simplify this. |
|
Thanks for the rapid response! I didn't want to remove it because some upstreams like to record this information for a variety of reasons, and from our perspective it truly doesn't matter (and is identical in intent) if we can pin the build date. Fortunately this is now already at zero maintenance. |
Because b951f62 (from PR #6) tried to add support for this, but it is not actually being used anywhere. The standard environment variable for defining reproducible build environments is SOURCE_DATE_EPOCH, which should be used to derive the BUILD_DATE macro rather than an environment variable matching said internal macro.
This is simplified even more by simply using the compiler's built-in macros for DATE and TIME when the file "about_scr.c" is processed by cpp. This natively supports SOURCE_DATE_EPOCH in the compiler itself.