images/line.png not found #486

Closed
ckhatri opened this Issue Oct 26, 2016 · 5 comments

Projects

None yet

4 participants

@ckhatri
Contributor
ckhatri commented Oct 26, 2016 edited

Whenever I try doing docker compose I get hit with
ERROR `/images/line.png' not found.

I found the issue is in stylesheet.css

  a.main, a:hover, .as-link.main, .as-link:hover {
    color: #2E7BA9;
    background-image: url(/images/line.png);
    background-repeat: repeat-x;
    background-position: left bottom; }

Not sure if line should be an actual file or if this is a typo. Thought I'd bring it up to people's attention!

Hope I did this issue stuff right. It's my first time.

@dahlbyk
Contributor
dahlbyk commented Oct 27, 2016

I'm inclined to remove the three background-* declarations - the existing link underline seems adequate to me.

@ckhatri how do you feel about closing your first issue with your first pull request? 😀

@ckhatri
Contributor
ckhatri commented Oct 27, 2016

yes please! just passed travis CI too, should be good to go.

@dahlbyk dahlbyk closed this in 725a7e8 Oct 27, 2016
@daveaglick
Contributor

Oh man, totally missed the notification on this one. I'm sure it was just a mistake/typo. Glad it got resolved! If it looks good, :shipit:

@daveaglick
Contributor

@ckhatri Congrats on your first PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment