Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logo anchor redirecting to / instead of /#/ #1466

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@SpaceEEC
Copy link
Contributor

commented Oct 7, 2019

Clicking on the logo anchor and then on any in-site link (can't find better term for this) sends you to the github pages 404 page.

How to reproduce this:

Small example as gif

V4kLHX4qNO

With this PR that behavior no longer occurs and clicking on tags etc. still works.

This caused clicking any further in-site anchor etc. to redirect to a not existing site (404).
Copy link
Member

left a comment

@SpaceEEC this is a great find - thanks for contributing the fix!

I re-tested the steps on the deploy link so this can be merged whenever CI passes.

@shiftkey shiftkey merged commit 479639b into up-for-grabs:gh-pages Oct 7, 2019
5 of 8 checks passed
5 of 8 checks passed
build
Details
build (12.x)
Details
build
Details
Header rules No header rules processed
Details
Pages changed 1 new file uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details
@shiftkey

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

@all-contributors please add @SpaceEEC for code

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2019

@shiftkey

I've put up a pull request to add @SpaceEEC! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.