New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop on unknown command line argument #28

Closed
Ortner opened this Issue Oct 10, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@Ortner

Ortner commented Oct 10, 2018

Issue

If you pass in the cert option, without equal sign but a space (should be true for the other options too) --cert ./app.crt instead of --cert=./app.crt the certificate is ignored silently. It took me quite a while to find out what's wrong (why didn't it fail with corrupt signatures). As --cert is parsed as own argument, it doesn't match the if clause in DefaultBootstrap and falls through to the end.

As the arguments are passed further to the main class to execute, not all arguments are known.

Solution

May be a further argument (i.e. --mainArgs) should be used to collect all the args, that are passed to the main class (i.e. --mainArgs="--arg1=3 --arg2 foo --arg3 bar"?

@mordechaim

This comment has been minimized.

Contributor

mordechaim commented Oct 10, 2018

Will try think of an out-of-the-box solution (I love them 😉)

@mordechaim

This comment has been minimized.

Contributor

mordechaim commented Oct 10, 2018

@mordechaim mordechaim closed this in 3d68cdf Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment