Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DefaultUpdateHandler #79

Closed
mordechaim opened this issue Jan 28, 2020 · 4 comments
Closed

Improve DefaultUpdateHandler #79

mordechaim opened this issue Jan 28, 2020 · 4 comments
Assignees

Comments

@mordechaim
Copy link
Contributor

@mordechaim mordechaim commented Jan 28, 2020

I want to redo the whole output of DefaultUpdateHandler. I think printing all files with their synchronization status is pointless and just noise.

Also I want to show progress and estimated completion.

@mordechaim mordechaim self-assigned this Jan 28, 2020
@yildiz-online

This comment has been minimized.

Copy link

@yildiz-online yildiz-online commented Jan 28, 2020

+1

Could be interesting, if not existing yet, to have events triggered so the application could subscribe to it.

@mordechaim

This comment has been minimized.

Copy link
Contributor Author

@mordechaim mordechaim commented Jan 28, 2020

That's precisely, my friend, what UpdateHandler is all about; subscribe to all possible events occuring while updating.

I'm only referring to the default implementation which just prints to the console.

@mordechaim

This comment has been minimized.

Copy link
Contributor Author

@mordechaim mordechaim commented Jan 28, 2020

Showing progress etc. depends on control chars that are not supported by some IDEs, we can just ignore this fact or check if we're running under an IDE.

@yildiz-online

This comment has been minimized.

Copy link

@yildiz-online yildiz-online commented Jan 29, 2020

Great design then, so for the default update handler, it is indeed noisy (but i will definitely give a check to the interface)

mordechaim added a commit that referenced this issue Feb 13, 2020
mordechaim added a commit that referenced this issue Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.