Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRC] Warning elimination and some minor reformating #6

Merged
merged 8 commits into from Dec 13, 2018
Merged

Conversation

@JJ
Copy link
Contributor

@JJ JJ commented Dec 2, 2018

I'm also working on new tests, but some stuff needs to be solved first.

README Outdated Show resolved Hide resolved
example/synopsis.pl Outdated Show resolved Hide resolved
example/synopsis.pl Outdated Show resolved Hide resolved
README Outdated Show resolved Hide resolved
@plicease
Copy link
Member

@plicease plicease commented Dec 3, 2018

I like this overall, I just had a few nits.

It would be good to use the [InsertExample] dzil plugin

https://metacpan.org/pod/Dist::Zilla::Plugin::InsertExample

For the synopsis example so that it only needs to be changed in one place.

JJ added 4 commits Dec 13, 2018
It needs pkgconf in this particular computer, so I've added it to
README. I've also followed instructions regarding the change of the example.
To use the dzil plugin, it would need to change overall to that
distribution method, as opposed to ExteUtils::Makemaker which is using
now, so I don't see a direct way of doing that. Maybe you can create
an issue to do it in the (near) future.
@plicease plicease merged commit 3e5bcd2 into uperl:master Dec 13, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@plicease
Copy link
Member

@plicease plicease commented Dec 13, 2018

Great! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants