Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring obsidian to the front at the time of the reminder #5

Closed
imeed166 opened this issue Aug 27, 2021 · 10 comments
Closed

bring obsidian to the front at the time of the reminder #5

imeed166 opened this issue Aug 27, 2021 · 10 comments

Comments

@imeed166
Copy link

@imeed166 imeed166 commented Aug 27, 2021

I am leaving obsidian open and hidden most of the time, so it would be nice if you could bring the obsidian window to the front when the reminder is fired. I don't know if it's easier, but I believe this is an alternative to the system notification support, no ?

@uphy
Copy link
Owner

@uphy uphy commented Aug 27, 2021

Actually, I've already implemented native notification but it is not activated:
https://github.com/uphy/obsidian-reminder/blob/master/src/ui/reminder.ts#L39-L47

I will create setting screen to enable this feature.

@imeed166
Copy link
Author

@imeed166 imeed166 commented Aug 27, 2021

Oh awesome, thank you.

@uphy
Copy link
Owner

@uphy uphy commented Aug 30, 2021

@imeed166 @wenlzhang Can you check v1.0.3?
I've implemented system notification feature roughly.
Please check Use system notification.

image

@Cito
Copy link

@Cito Cito commented Aug 30, 2021

Really useful feature. Just tested this on Windows 10, works great!

@imeed166
Copy link
Author

@imeed166 imeed166 commented Aug 30, 2021

Yes @uphy it works great, thank you. But if I use system notification, I can't postpone the task. So 2 solutions comes to mind :

  • implement a native way to postpone the reminder with the option specified in the plugin settings (like in the screenshots)
  • keep both system notification and obsidian notification enabled, so that when I get a reminder, I can postpone it by opening obsidian.
    image
    image

@uphy
Copy link
Owner

@uphy uphy commented Aug 30, 2021

@imeed166 When you click the notification (not close button, left part of the it), an reminder modal should be seen in Obsidian.
In the modal, you can postpone the task as you did before.
(maybe solution 2)

Also, the Later options in the system notification is possible only in Mac. (the API seems not available on Windows)
I can implement it in the future 👍🏼

@imeed166
Copy link
Author

@imeed166 imeed166 commented Aug 30, 2021

I see, perfect, solution 2 is already here. Yes, a mac specific implementation would be nice, but I think that it's already very functional as it is, so I think you should focus on other more urgent issues for now. Thank you again for this great plugin.

@uphy
Copy link
Owner

@uphy uphy commented Aug 30, 2021

I'm glad to hear that.
Thank you for suggesting cool features!

@uphy
Copy link
Owner

@uphy uphy commented Aug 30, 2021

I close this issue.
Instead, I create another issue for supporting system notification actions.

@wenlzhang
Copy link

@wenlzhang wenlzhang commented Aug 30, 2021

Thank you, @uphy , for implementing this! It works like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants