Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this.renderer.destroyNode is not a function on production build #26

Closed
TwunTee opened this issue Oct 13, 2018 · 4 comments
Closed

this.renderer.destroyNode is not a function on production build #26

TwunTee opened this issue Oct 13, 2018 · 4 comments

Comments

@TwunTee
Copy link

@TwunTee TwunTee commented Oct 13, 2018

The widget works fine when built using dev. When it is built for production I am getting an error
"""
this.renderer.destroyNode is not a function
"""
It happens after the file is uploaded. destroyNode function can be null during production as per angular docs. An stackoverflow thread with similar issue https://stackoverflow.com/questions/44465653/what-is-the-correct-way-to-destroy-an-element-created-with-renderer2

@TwunTee
Copy link
Author

@TwunTee TwunTee commented Oct 15, 2018

@bautrukevich @ZNick1982 can someone look into this please? I fixed this issue using the solution from stackoverflow but not sure which npm script to run to create a release version.

@ZNick1982
Copy link
Contributor

@ZNick1982 ZNick1982 commented Oct 16, 2018

Hello @TwunTee
Thanks for reporting this.
I will take a look.

Kind regards,
Nikolay Zherdev

@ZNick1982
Copy link
Contributor

@ZNick1982 ZNick1982 commented Oct 23, 2018

Hello @TwunTee
Fixed in https://github.com/uploadcare/ngx-uploadcare-widget/tree/v1.2.2_node_fix
Can you please check?

Kind regards,
Nikolay Zherdev.

@TwunTee
Copy link
Author

@TwunTee TwunTee commented Oct 25, 2018

The error is fixed!

@TwunTee TwunTee closed this Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants