Fix locales and add fallback if locale doesn't exists #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nd0ut
requested changes
Feb 13, 2019
Zmoki
suggested changes
Feb 13, 2019
src/create-preview-tab-effects.js
Outdated
| // Add fallback if locale doesn't exists | ||
| if (!isLocaleExists) { | ||
| uc.locale.translations[currentLocale] = translations.en | ||
| } |
There was a problem hiding this comment.
You totally rewrite locale for the preview tab with en. You need to use the en locale for effects only if custom locale doesn‘t exist in Effects Tab.
Preview tab without Effects Tab on Poland:
Preview tab with Effects Tab on Poland (title and main buttons on english too):
| ru, | ||
| vi, |
There was a problem hiding this comment.
Oops, I missed it before. Thank you!
Co-Authored-By: bautrukevich <bautrukevich@users.noreply.github.com>
Zmoki
approved these changes
Feb 14, 2019
nd0ut
approved these changes
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.