Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locales and add fallback if locale doesn't exists #29

Merged
merged 4 commits into from Feb 18, 2019

Conversation

Projects
None yet
3 participants
@bautrukevich
Copy link
Member

commented Feb 13, 2019

No description provided.

@bautrukevich bautrukevich requested review from Zmoki and nd0ut Feb 13, 2019

Show resolved Hide resolved src/tools/configure-translations.js Outdated
// Add fallback if locale doesn't exists
if (!isLocaleExists) {
uc.locale.translations[currentLocale] = translations.en
}

This comment has been minimized.

Copy link
@Zmoki

Zmoki Feb 13, 2019

Contributor

You totally rewrite locale for the preview tab with en. You need to use the en locale for effects only if custom locale doesn‘t exist in Effects Tab.

Preview tab without Effects Tab on Poland:
2019-02-13 16 48 09

Preview tab with Effects Tab on Poland (title and main buttons on english too):
2019-02-13 16 48 45

ru,
vi,

This comment has been minimized.

Copy link
@Zmoki

Zmoki Feb 13, 2019

Contributor

Oops, I missed it before. Thank you!

nd0ut and others added some commits Feb 13, 2019

Update src/tools/configure-translations.js
Co-Authored-By: bautrukevich <bautrukevich@users.noreply.github.com>
@Zmoki

Zmoki approved these changes Feb 14, 2019

@nd0ut

nd0ut approved these changes Feb 18, 2019

@bautrukevich bautrukevich merged commit 448d258 into master Feb 18, 2019

1 check passed

License Compliance All checks passed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.