New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacky fix video seeking on chrome #460

Merged
merged 2 commits into from May 16, 2018

Conversation

Projects
None yet
3 participants
@nd0ut
Contributor

nd0ut commented May 14, 2018

There is a bug in Chrome MediaRecorder API:
https://bugs.chromium.org/p/chromium/issues/detail?id=569840

It doesn't write video duration to the file header so it's not available util the end of video not reached.
This hack do the following:

  1. Set currentTime to some big value - 360000 seconds (100 hours)
  2. Video player reaches the end of file and determines video duration
  3. Set currentTime back to zero
  4. Seeking is now working

nd0ut added some commits May 14, 2018

@nd0ut nd0ut requested review from Zmoki and homm May 14, 2018

@Zmoki

Zmoki approved these changes May 15, 2018

@homm

homm approved these changes May 15, 2018

@nd0ut nd0ut merged commit af0a6ca into master May 16, 2018

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details

@nd0ut nd0ut deleted the fix/video-seeking branch May 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment