New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run validators on each chunk of data #511

Merged
merged 3 commits into from Nov 28, 2018

Conversation

Projects
None yet
2 participants
@homm
Copy link
Contributor

homm commented Nov 19, 2018

No more single onInfoReady event. Each chunk of data will be processed with validators (hope they are fast enough).

wait_is_ready flag is set depending on isImage: if isImage is not set, we don't wait for is_ready.

@homm homm requested a review from nd0ut Nov 19, 2018

@Zmoki
Copy link
Member

Zmoki left a comment

Add note to changelog under Unreleased

* Fixed multipart uploading when imagesOnly flag is set.
* Validators now run more frequently for each file than before.
* Fixed typo and improved grammar in the Dutch (`nl`) locale. See [#504][github-pr-504].

This comment has been minimized.

@homm

homm Nov 27, 2018

Author Contributor

Rearranged according to the importance

@homm homm requested a review from Zmoki Nov 27, 2018

@Zmoki

Zmoki approved these changes Nov 28, 2018

@Zmoki Zmoki merged commit 6b173cf into master Nov 28, 2018

1 check was pending

continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@Zmoki Zmoki deleted the run-validators-on-each-chunk-of-data branch Nov 28, 2018

Zmoki added a commit that referenced this pull request Dec 6, 2018

Zmoki added a commit that referenced this pull request Dec 6, 2018

Add link to pr #511 to changelog
(cherry picked from commit aaf7a07)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment