Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for all known video containers with fallback to AVI #516

Merged
merged 1 commit into from Nov 30, 2018

Conversation

@homm
Copy link
Contributor

@homm homm commented Nov 29, 2018

No description provided.

if Object.keys(__recorderOptions).length != 0
@__recorder = new @MediaRecorder(@__stream, __recorderOptions)
else
@__recorder = new @MediaRecorder(@__stream)

This comment has been minimized.

@homm

homm Nov 29, 2018
Author Contributor

Restore the original safe code since MDN says there are browsers who don't support the second argument.

'ogg': 'ogg',
'webm': 'webm',
'quicktime': 'mov',
'x-matroska': 'mkv',

This comment has been minimized.

@homm

homm Nov 29, 2018
Author Contributor

There are all popular video containers. A container (not codecs) defines actual file extension.

if known_containers[container]
return known_containers[container]
# In all other cases just return the base extension for all times
return 'avi'

This comment has been minimized.

@homm

homm Nov 29, 2018
Author Contributor

Fallback to well known avi to prevent awful extension like x-matroska;codecs=avc1,opus in the future.

@homm homm requested a review from Zmoki Nov 29, 2018
@Zmoki
Zmoki approved these changes Nov 30, 2018
Copy link
Contributor

@Zmoki Zmoki left a comment

Add note to changelog

@homm homm merged commit 2f4875b into master Nov 30, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/push The Travis CI build passed
Details
@homm homm mentioned this pull request Nov 30, 2018
homm added a commit that referenced this pull request Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants