New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard only users can navigate the dialog #524

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
2 participants
@robbiepaul
Copy link
Contributor

robbiepaul commented Dec 14, 2018

  • When the dialog opens the user's focus should go to the first focusable element within the dialog.
  • When tabbing focus within an open modal dialog the focus should be constrained to elements within the open modal only. The focus should not go to elements outside the dialog.
  • When the dialog closes the focus should be returned to the originating element outside the dialog.

https://www.w3.org/TR/wai-aria-practices/#dialog_modal

Fixes #514

Lock the focus to the dialog elements
When tabbing focus within an open modal dialog the focus should be
constrained to elements within the open modal only. The focus should not
go to elements outside the dialog.

When the dialog closes focus should be returned to the originating
element outside the dialog.

https://www.w3.org/TR/wai-aria-practices/#dialog_modal
@Zmoki

This comment has been minimized.

Copy link
Member

Zmoki commented Dec 17, 2018

Wow! @robbiepaul thank you! I‘ll check it and return to you tomorrow

@Zmoki

Zmoki approved these changes Jan 30, 2019

@Zmoki

This comment has been minimized.

Copy link
Member

Zmoki commented Jan 30, 2019

@robbiepaul hi! Sorry for the delay, long new year vacation and I was busy with the new uploader. I checked you PR, great work! It will be published soon.

@Zmoki Zmoki merged commit c579075 into uploadcare:master Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment