New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonRPC selective disclose #45

Merged
merged 2 commits into from Dec 20, 2018

Conversation

Projects
None yet
2 participants
@ajunge
Copy link
Contributor

ajunge commented Dec 18, 2018

No description provided.

@wafflebot wafflebot bot added the review label Dec 18, 2018

@ajunge ajunge requested a review from pelle Dec 18, 2018

@pelle
Copy link
Contributor

pelle left a comment

Please see my comments @ajunge

@@ -30,6 +30,7 @@ Name | Description | Required
`boxPub` | 32 byte base64 encoded [`Curve25519`](http://nacl.cr.yp.to/box.html) public key of requesting identity. Use to encrypt messages sent to callback URL| no
`issc` | The self signed claims for the `iss` of this message. Either as an Object of claim types for self signed claims eg: `{"name":"Some Corp Inc", "url":"https://somecorp.example","image":{"/":"/ipfs/QmSCnmXC91Arz2gj934Ce4DeR7d9fULWRepjzGMX6SSazB"}}` or the IPFS Hash of a JSON encoded equivalent. See [Issuer Claims](/messages/claims.md) | no
`vc` | Array of Verified Claims JWTs or IPFS hash of JSON encoded equivalent about the `iss` of this message. See [Issuer Claims](/messages/claims.md) and [Verified Claims](/messages/verification.md) | no
`jsonRPC` | URL for the JSON RPC endpoint, ie: `https://mainnet.infura.io/`. Useful for private networks. The `net_version` method shoud return the same networkId as the filed `net`. The JSON RPC endpoint must provide method `eth_sendRawTransaction` (https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_sendrawtransaction) | no

This comment has been minimized.

@pelle

pelle Dec 19, 2018

Contributor

Could we just use rpc instead of jsonRPC. Much smaller and slimmer.

Link to this page and update the description to which methods are required: private chain flow. Not sure the diagram makes any sense anymore.

Finally please remove the old Private Chain Provisioning Message

The mobile app needs the following implemented:

  • eth_getTransactionCount
  • eth_getBalance
  • eth_estimateGas
  • eth_getGasPrice
  • eth_sendRawTransaction
  • eth_getTransactionReceipt
@pelle

pelle approved these changes Dec 20, 2018

Copy link
Contributor

pelle left a comment

Perfecto

@pelle pelle merged commit ba4fe93 into develop Dec 20, 2018

@wafflebot wafflebot bot removed the review label Dec 20, 2018

@ajunge ajunge deleted the feature/private-chain branch Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment