Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow publishing only CLEAN or only INFECTED results #78

Conversation

@chrisgilmerproj
Copy link
Contributor

commented Sep 6, 2019

This change allows only publishing to SNS if the scan result is CLEAN or INFECTED. By default it will publish both which was the previous default.

Background: My company doesn't want to know if the results are CLEAN. They only want notifications if the results are INFECTED which will kick off additional work for our infrastructure team.

The alternative approach I considered was having an SNS topic ARN for CLEAN and one for INFECTED so that they could be treated differently. However this seemed like it would be backwards incompatible and I don't know the project's tolerance for that kind of change.

scan.py Outdated Show resolved Hide resolved
chrisgilmerproj and others added 2 commits Sep 11, 2019

@jaygorrell jaygorrell merged commit 524838b into upsidetravel:master Sep 11, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@chrisgilmerproj chrisgilmerproj deleted the chrisgilmerproj:cg_manage_publish_clean_infected branch Sep 11, 2019

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

I think this closes #29

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

This may also be related to #65 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.