Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python tests #89

Merged
merged 25 commits into from Oct 14, 2019

Conversation

@chrisgilmerproj
Copy link
Collaborator

commented Oct 2, 2019

This PR is intended to only add tests and no new functionality. A few of the functions will be modified to allow for unit tests but the function should be exactly the same.

I haven't been able to upload this to my running lambda. I need one feature in this code base that is not implemented yet because I wanted tests in place before attempting to add the feature. Please review changes to scan.py with some care.

You can now run this to get coverage:

pip install -r requirements-dev.txt
make coverage
@chrisgilmerproj chrisgilmerproj self-assigned this Oct 2, 2019
…cts into main lambda handler in order to test path changes
@chrisgilmerproj chrisgilmerproj changed the title WIP: Add Python tests Add Python tests Oct 3, 2019
@chrisgilmerproj chrisgilmerproj requested review from denniswebb and jaygorrell Oct 3, 2019
@chrisgilmerproj chrisgilmerproj marked this pull request as ready for review Oct 3, 2019
@chrisgilmerproj

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 11, 2019

@jaygorrell - I think there's still an issue with branch protection on this one. But it's ready to go. Can you take a look?

@jaygorrell jaygorrell closed this Oct 14, 2019
@jaygorrell jaygorrell reopened this Oct 14, 2019
@jaygorrell jaygorrell merged commit cee96ae into master Oct 14, 2019
5 checks passed
5 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: pre_commit_deps Your tests passed on CircleCI!
Details
ci/circleci: pre_commit_test Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
@jaygorrell jaygorrell deleted the cg_python_tests branch Oct 14, 2019
@jaygorrell

This comment has been minimized.

Copy link
Contributor

commented Oct 14, 2019

All good now. Thanks for this one!

@jaygorrell jaygorrell referenced this pull request Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.