New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users can use their Nickname to Log in. #166

Closed
helenvarley opened this Issue May 22, 2017 · 12 comments

Comments

Projects
None yet
5 participants
@helenvarley

helenvarley commented May 22, 2017

currently it's only possible to log in with your email address. previously in UpStage it has always been username. is there a reason for using email address? if there's no reason, then i'd prefer username - simply because it's quicker ...

@prohrlac

This comment has been minimized.

Member

prohrlac commented May 22, 2017

Erm... I think it's because I added nicknames after the fact.

@helenvarley

This comment has been minimized.

helenvarley commented May 22, 2017

ok; can it be possible to log in with either? (could be useful to log in with email if you've forgotten your username?)

@vickis

This comment has been minimized.

vickis commented May 22, 2017

@prohrlac

This comment has been minimized.

Member

prohrlac commented May 22, 2017

Yes of course

@prohrlac prohrlac removed their assignment Apr 10, 2018

@charlie0605

This comment has been minimized.

Contributor

charlie0605 commented Apr 11, 2018

@rohrlach can the user just use their nickname to login or do they have to have a username?

@thongteav

This comment has been minimized.

Contributor

thongteav commented Apr 11, 2018

I would imagine that they're in the same text field. But I could be wrong.

@helenvarley

This comment has been minimized.

helenvarley commented Apr 11, 2018

username & nickname are the same

@prohrlac

This comment has been minimized.

Member

prohrlac commented Apr 11, 2018

That's correct.

Unfortunately, we've created ambiguity where the term 'nickname' can refer to the nickname field for the User model and also the concept of renaming an avatar in the performance space.

I used the term "nickname" for users because it's not a defining characteristic (IE: can be changed at will) so linguistically, this made more sense to me.

In any case, @thongteav is correct - a user should see something like this:

image
And should work as implied.

I may opt to rename the field on the user model, but I'll open a new issue for that.

@prohrlac prohrlac changed the title from login with username to Users can use their Nickname to Log in. Apr 11, 2018

@prohrlac

This comment has been minimized.

Member

prohrlac commented Apr 11, 2018

Also note - being that this a security related change, I will be scrutinizing the solution carefully.

@charlie0605 charlie0605 self-assigned this Apr 11, 2018

prohrlac pushed a commit that referenced this issue Apr 12, 2018

Issue #166 (#326)
* Players are able to use their nickname or email to login

* Change input placeholder

* Changed email validation method
@helenvarley

This comment has been minimized.

helenvarley commented Apr 15, 2018

i would be inclined to go for "username" for something that refers to the player, since they are the user.
to me "nickname" could relate to the avatar. especially as in UpStage we have always had the command "/nick" to change the name of the avatar ...

prohrlac pushed a commit that referenced this issue Apr 18, 2018

Paul Rohrlach
Amend Issue #166 (#329)
* Rename User.nickname to User.username

* Enforce Lowercase Usernames

Because usernames are now being used for logins, we must be mindful of how we match.  An ActiveRecord query like find_by_username will assume case sensitivity and thus won't match 'User' and 'user'.

Solution: ensure all existing usernames are stored in lowercase (and going forward) and also force the downcasing of the uid param

* Must also ensure email is lowercase

@prohrlac prohrlac added this to the R6-2018 milestone Apr 18, 2018

@prohrlac

This comment has been minimized.

Member

prohrlac commented Apr 18, 2018

@helenvarley I have renamed the field as requested. Please validate.

@helenvarley

This comment has been minimized.

helenvarley commented Apr 19, 2018

yep, looks good & works :)

@prohrlac prohrlac closed this Apr 20, 2018

@prohrlac prohrlac referenced this issue Apr 26, 2018

Merged

R6 2018 #332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment