New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar Speech Bubbles #190

Closed
prohrlac opened this Issue Jun 21, 2017 · 13 comments

Comments

Projects
None yet
4 participants
@prohrlac
Member

prohrlac commented Jun 21, 2017

If a player is holding an avatar and that avatar is on the stage - Whatever that player enters into the chat should be displayed in a speech bubble above the avatar. Styling for chat modifiers must be followed.

@charlie0605

This comment has been minimized.

Contributor

charlie0605 commented May 17, 2018

@helenvarley @vickis @rohrlach
I've got the speech bubble drawing like this
image

The normal speech can adjust itself according to the amount of text you type.
image

For Shout Im having trouble drawing it like the old UpStage would something like this be ok?
image

If the shout is drawn like this it will also allow height to be automatically adjusted when long message is sent.
image

The speech bubble will stay on the stage for 3 seconds and disappear is that long enough?

@prohrlac

This comment has been minimized.

Member

prohrlac commented May 17, 2018

That looks great 😄 Could we perhaps have it show for 5 seconds? Also, can the shout text be bold?

@helenvarley

This comment has been minimized.

helenvarley commented May 17, 2018

looking good. previously the speech bubble faded out - will that also happen? it's a nice effect. & the longer the amount of text, the longer the bubble stayed before fading. can you do that? :)

@helenvarley

This comment has been minimized.

helenvarley commented May 17, 2018

oh and another thing about speech bubbles: they are normally above the avatar, but if your avatar is near the top of the stage so that the bubble wouldn't be visible, it needs to display below the avatar.

@prohrlac prohrlac removed avatars labels May 17, 2018

@charlie0605

This comment has been minimized.

Contributor

charlie0605 commented May 17, 2018

as a base is 3 seconds timeout long enough?

in this case it will be 6 seconds
image

In regards to fading I'm not sure if I could do that in canvas @rohrlach do you know if its possible?

also does this bold look ok for the shout?
image

@vickis

This comment has been minimized.

vickis commented May 17, 2018

@thongteav thongteav referenced this issue May 17, 2018

Merged

Issue#190 #349

@prohrlac prohrlac added this to the R8-2018 milestone May 18, 2018

prohrlac pushed a commit that referenced this issue May 20, 2018

Issue #190 (#349)
* Drawing speech bubble and shout bubble
- when player use "Speech" Green bubble will pop up above the avatar.
- When player use "shout" red spikes will pop up above the avatar.

- Currently only works for local, audience and other player are not able
to see it

* Player can see speech bubbles
- When player's avatar is too hight speech bubble is drawin below.
- Shout text is bold in the speech bubble
- The longer the text the longer it takes for the speech bubble to
disappare.

* Added Thought bubble and refactor the code

* Adjusting thought bubble

* Fixed message issue
Message is show correctly now

* refractor code into functions

* create variable for hard coded values

* added more variable

* remove spacing

* variable update

* update variable name

@prohrlac prohrlac assigned helenvarley and vickis and unassigned charlie0605 May 20, 2018

@prohrlac

This comment has been minimized.

Member

prohrlac commented May 20, 2018

Appears to work.

Some refactoring is needed, but that's not a big problem given our pre-release status.

Will wait for someone to test and close (If appropriate)

@prohrlac

This comment has been minimized.

Member

prohrlac commented May 20, 2018

Having tried it, I think 5 seconds is still too short. But we can raise a new issue for upping the delay.

@vickis

This comment has been minimized.

vickis commented May 20, 2018

@helenvarley

This comment has been minimized.

helenvarley commented May 20, 2018

length of time doesn't seem too short, but there is no fade out. the bubble just disappears (in firefox on linux)

@prohrlac

This comment has been minimized.

Member

prohrlac commented May 21, 2018

There's no code to make it fade out.

as it stands, making the bubbles fade out will be a performance hit without significant changes to the way frames are rendered. I have plans to address this, but I think it's unwise to try and shoe-horn it in at this time.

My suggestion is to accept the bubbles as-is for now, and then we add fade later.

@vickis

This comment has been minimized.

vickis commented May 21, 2018

@helenvarley

This comment has been minimized.

helenvarley commented May 21, 2018

ok :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment