New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drawing when in avatar palette #194

Closed
helenvarley opened this Issue Jun 21, 2017 · 10 comments

Comments

Projects
None yet
4 participants
@helenvarley

helenvarley commented Jun 21, 2017

i tried moving an avatar with click & drag instead of point & click, & ended up drawing a line. drawing should only happen when you have the drawing palette activated, otherwise you can easily end up accidentally drawing with a slip of the mouse.

@prohrlac

This comment has been minimized.

Member

prohrlac commented Jun 23, 2017

Click-and-drag movement isn't implemented yet. But yes, there's nothing that locks drawing.

@helenvarley

This comment has been minimized.

helenvarley commented Jun 24, 2017

@vickis might have a different opinion, but i don't think that the default state for your cursor on the stage should be the drawing tool. it is too easy to accidentally draw. normally you would want to make the conscious decision, by activating the drawing palette, to start drawing on the stage.

@prohrlac

This comment has been minimized.

Member

prohrlac commented Jun 24, 2017

That's correct, hence 'confirmed bug'

@vickis

This comment has been minimized.

vickis commented Jun 25, 2017

i had not noticed that ... er probably becasue i always head for the drawing palette to test
concur that this is not a great 'default' state for most users :)

@charlie0605

This comment has been minimized.

Contributor

charlie0605 commented Apr 10, 2018

@helenvarley @vickis
Can you please clarify this issue?
From my understanding:
Drawing on stage should only be enabled when the player is on the drawing palette. If they are on any other palette, drawing should be disabled. if they are on the drawing palette then drawing is enabled for them and avatar dropping and dragging function is to be disabled

so if a player is on avatar palette then they should not be able to draw, they should only have access to avatar functionalities.

@helenvarley

This comment has been minimized.

helenvarley commented Apr 10, 2018

yes, that's correct :)

@charlie0605

This comment has been minimized.

Contributor

charlie0605 commented Apr 10, 2018

194
would something like that look right, its a bit hard to see me clicking on the page

@helenvarley

This comment has been minimized.

helenvarley commented Apr 10, 2018

yes, that looks great! :)

@charlie0605 charlie0605 self-assigned this Apr 10, 2018

prohrlac pushed a commit that referenced this issue Apr 11, 2018

@prohrlac prohrlac added this to the R6-2018 milestone Apr 11, 2018

@prohrlac prohrlac assigned helenvarley and vickis and unassigned charlie0605 Apr 11, 2018

@helenvarley

This comment has been minimized.

helenvarley commented Apr 15, 2018

works for me 👍

@prohrlac prohrlac referenced this issue Apr 26, 2018

Merged

R6 2018 #332

@prohrlac

This comment has been minimized.

Member

prohrlac commented Apr 29, 2018

Assuming this is complete based on the discussion

@prohrlac prohrlac closed this Apr 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment