New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button to clear unheld avatars #202

Closed
helenvarley opened this Issue Jun 25, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@helenvarley

helenvarley commented Jun 25, 2017

there should be a way to clear all unheld avatars from the stage (as currently exists in UpStage)

@helenvarley helenvarley added the avatars label Jun 25, 2017

@prohrlac prohrlac removed their assignment Apr 10, 2018

@charlie0605 charlie0605 self-assigned this Apr 11, 2018

@prohrlac prohrlac removed the avatars label May 17, 2018

@prohrlac prohrlac assigned prohrlac and unassigned charlie0605 May 18, 2018

prohrlac pushed a commit that referenced this issue May 23, 2018

Issue #202 (#325)
* Players are able to clear all unheld avatars
- minor bug fix, when player drops avatar, the avatar button title is the avatar name where as previous the title is undefined

* update

* Change variable names and minor code update

* Removed console log

@prohrlac prohrlac added this to the R8-2018 milestone May 23, 2018

@prohrlac prohrlac assigned helenvarley and vickis and unassigned prohrlac May 23, 2018

@helenvarley

This comment has been minimized.

helenvarley commented May 23, 2018

where is the clear button?

@charlie0605

This comment has been minimized.

Contributor

charlie0605 commented May 23, 2018

@helenvarley I don't think its available on QA yet

@charlie0605

This comment has been minimized.

Contributor

charlie0605 commented May 24, 2018

@helenvarley looks like its on QA now

@helenvarley

This comment has been minimized.

helenvarley commented May 24, 2018

great! :) it appears to work (on firefox + linux) BUT we really need to add some more media in order to test it properly. there are only 3 avatars currently on limelight & i think this isn't enough to give us confirmation that clearing is working properly. i'm working intensively until saturday then travelling all day saturday so no time to upload anything myself.
(i still find it really frustrating having to scroll in the tool panels - i know there is an issue for this, maybe i'll bump up its priority!!)

@prohrlac

This comment has been minimized.

Member

prohrlac commented Aug 11, 2018

@helenvarley can we close this issue?

@helenvarley

This comment has been minimized.

helenvarley commented Aug 16, 2018

well i just tested it again & the clear button did not do anything, so no, it appears to be NOT working ... i have only tried on firefox on linux, on the hentest stage where there are only 2 avatars. i will upload some more avatars & try again.

@helenvarley

This comment has been minimized.

helenvarley commented Aug 16, 2018

i added some more avatars & tried it again, & it worked. so ... let's close it for now, & if it proves to be buggy then we can always open a new issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment