New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avatar names - changing the name on stage #205

Closed
helenvarley opened this Issue Jun 25, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@helenvarley

helenvarley commented Jun 25, 2017

it should be possible to change an avatar's name on stage. in UpStage this has always been done with a command - which is not very intuitive / easy for newbies. ideally it should be possible to change it in the avatar tool palette by typing in the new name.

@helenvarley helenvarley added the avatars label Jun 25, 2017

@thongteav thongteav referenced this issue Oct 7, 2017

Closed

Rename Avatars #13

@charlie0605 charlie0605 assigned charlie0605 and unassigned rohrlach Nov 29, 2017

rohrlach pushed a commit that referenced this issue Dec 22, 2017

Issue #205 (#289)
* changing avatart name on stage

players allow to change avatar name on stage, but the name will change back once the avatar is moved.

* Avatar name is able to be edited on stage

The players are allowed to edit avatar name on stage.
When the player refreash the page the avatar name is back to original

* remove unused code and rename variable

* moved sytle into stylesheets

* edit name button and input field will not disable if other player is holding an avatar too.

* update bug

The array of nickname is broadcasted so that all user can have the same nickname for the same avatar.
When multiple user on the same stage, edtiting function is not working properly

* Players are able to change avatar name

fixed bug where the name is not showing on other users page unless the avatar is placed again

* Update

@rohrlach rohrlach assigned helenvarley and vickis and unassigned charlie0605 Dec 22, 2017

@upstage-org upstage-org deleted a comment from helenvarley Dec 23, 2017

@helenvarley

This comment has been minimized.

Show comment
Hide comment
@helenvarley

helenvarley Dec 25, 2017

this works, in that i can change the name in the avatar palette & it appears on the stage. however, when my avatar speaks, it shows my player name, not the name of the avatar, in the chat window.
also: it's no good having to scroll down in the avatar palette to do this. the palette needs to take more space from the chat window (to sit over the top of it). scrolling is no good when we are performing & need to do things quickly.
the button says "edit" but maybe should say "save", since you've already edited the name & clicking the button saves it.

helenvarley commented Dec 25, 2017

this works, in that i can change the name in the avatar palette & it appears on the stage. however, when my avatar speaks, it shows my player name, not the name of the avatar, in the chat window.
also: it's no good having to scroll down in the avatar palette to do this. the palette needs to take more space from the chat window (to sit over the top of it). scrolling is no good when we are performing & need to do things quickly.
the button says "edit" but maybe should say "save", since you've already edited the name & clicking the button saves it.

@rohrlach rohrlach added this to the Sprint 13 milestone Feb 14, 2018

@rohrlach rohrlach removed this from the Sprint 13 milestone Mar 14, 2018

@rohrlach rohrlach assigned charlie0605 and unassigned helenvarley and vickis Mar 14, 2018

@charlie0605

This comment has been minimized.

Show comment
Hide comment
@charlie0605

charlie0605 Mar 26, 2018

Contributor

in regards to "scrolling is no good when we are performing & need to do things quickly" does this get done in this issue or #295 ?

Contributor

charlie0605 commented Mar 26, 2018

in regards to "scrolling is no good when we are performing & need to do things quickly" does this get done in this issue or #295 ?

@rohrlach

This comment has been minimized.

Show comment
Hide comment
@rohrlach

rohrlach Mar 27, 2018

Member

I assume #295

@helenvarley do you agree?

Member

rohrlach commented Mar 27, 2018

I assume #295

@helenvarley do you agree?

@rohrlach rohrlach added this to the R5-2018 milestone Mar 27, 2018

rohrlach pushed a commit that referenced this issue Apr 4, 2018

Issue #205 (#318)
* Changed the name of edit button to save

* Remove active class in avatar and backdrop tab

* Chat name adjusted
If the player is holding an avatar and they message on the chat, their name will be displayed as their avatar nickname
If the player is not holding an avatar then their name displayed on the chat will the their username

* Chat name adjusted
If the player is holding an avatar and they message on the chat, their name will be displayed as their avatar nickname
If the player is not holding an avatar then their name displayed on the chat will the their username

* Remove log message

* Changed variable name

* Avatar and backdrop now shows image when you click the tab

* Added new migration file

@rohrlach rohrlach assigned helenvarley and vickis and unassigned charlie0605 Apr 4, 2018

@helenvarley

This comment has been minimized.

Show comment
Hide comment
@helenvarley

helenvarley Apr 4, 2018

works for me - only tested on firefox on linux :)

helenvarley commented Apr 4, 2018

works for me - only tested on firefox on linux :)

@rohrlach

This comment has been minimized.

Show comment
Hide comment
@rohrlach

rohrlach Apr 4, 2018

Member

I too, think this is working as expected.

Member

rohrlach commented Apr 4, 2018

I too, think this is working as expected.

@rohrlach rohrlach closed this Apr 4, 2018

@rohrlach rohrlach referenced this issue Apr 4, 2018

Merged

R5-2018 #320

rohrlach pushed a commit that referenced this issue Apr 8, 2018

Paul Rohrlach
R5-2018 (#320)
* Bump Ruby version to 2.5.0 (#311)

* Issue #312 (#313)

CVE-2018-8048

* Issue #315 (#316)

According to rails/rails#31517 updating the nio4r gem is the solution.  It appears to work.

* Issue #210 (#310)

* Table for media items with the respective shown on the tag page

* tags added into table, should be media items

* Table show, unable to get media showing in table

* Table should display backdrop, sound and stage media. Avatars not showing yet

* avatar should display in table. Table does not sort yet

* Table now sorts by name or type when clicking the column heading

* indentation fixed to show.html.erb and tags.all in show method in tags controller removed

* Removed white spacing and adjust indentation

* Remove Spaces

In HTML, there shouldn't be spaces either side of an ```=``` like you would see in Ruby or Javascript

* Update Rails 5.1.6

Minor release. Applies latest security and bug fixes

* Issue #254 (#317)

* Changed delete messages. Delete messages are now
more consistent.

* Inconsistent messages are now of the same style as other messages.

* Wording changed in delete message. "from the server"
removed and changed to "immediately"

* Fix Typo

* Issue #205 (#318)

* Changed the name of edit button to save

* Remove active class in avatar and backdrop tab

* Chat name adjusted
If the player is holding an avatar and they message on the chat, their name will be displayed as their avatar nickname
If the player is not holding an avatar then their name displayed on the chat will the their username

* Chat name adjusted
If the player is holding an avatar and they message on the chat, their name will be displayed as their avatar nickname
If the player is not holding an avatar then their name displayed on the chat will the their username

* Remove log message

* Changed variable name

* Avatar and backdrop now shows image when you click the tab

* Added new migration file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment