New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stage accessibility - public or non-public #242

Open
helenvarley opened this Issue Sep 13, 2017 · 9 comments

Comments

Projects
None yet
4 participants
@helenvarley

helenvarley commented Sep 13, 2017

it should be possible to make a stage "public" - i.e. visible to someone who is not logged in, in the list of stages on the foyer page - or "non-public" - i.e. only visible to logged in players who have access to that stage.
it should be an option that can be set in the stage edit screen.

@prohrlac

This comment has been minimized.

Member

prohrlac commented Sep 13, 2017

You mention "access to the stage"

Does this mean we need to create a permissions system?

@helenvarley

This comment has been minimized.

helenvarley commented Sep 13, 2017

yes ... would that be a separate issue, i guess?? ;)

@prohrlac

This comment has been minimized.

Member

prohrlac commented Sep 13, 2017

Yes, #243 is necessary and should be done first.

But this is still valid.

@prohrlac prohrlac removed their assignment Sep 13, 2017

@thongteav

This comment has been minimized.

Contributor

thongteav commented May 16, 2018

@helenvarley Just like to clarify a few points on this issue:

  • On foyer page I've added a visibility column, so that a logged in user can see whether a stage is public or not.
    image
    Audience won't see this column nor non-public stages:
    image

  • For assigning public or non-public stages, you can do it when you create a stage or in the stage edit page:
    image
    image

  • Restriction to the stages will be done in #243

Is there anywhere else you'd like the player to see whether a stage is public or not. Maybe in the stages list page or each stage index page?

@prohrlac

This comment has been minimized.

Member

prohrlac commented May 16, 2018

The access column could show for audience - and just say that access level is audience?

@helenvarley

This comment has been minimized.

helenvarley commented May 16, 2018

@thongteav yes it makes sense to include the public/non-public status in the stages list page, as well as on each stage edit page.

@rohrlach - would audience be confused, seeing a column called "access" that always has "audience" in it? is it difficult to hide this column from the audience?

@prohrlac

This comment has been minimized.

Member

prohrlac commented May 16, 2018

Sure - I was just thinking about how it is now. But sure, my preference would be hide useless information wherever possible 😄

@vickis

This comment has been minimized.

vickis commented May 16, 2018

@prohrlac prohrlac removed stages labels May 17, 2018

@thongteav

This comment has been minimized.

Contributor

thongteav commented May 22, 2018

  • Added an 'accessibility' column in the stage list page:
    image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment