New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar Shrink-and-Grow #304

Closed
helenvarley opened this Issue Mar 14, 2018 · 13 comments

Comments

Projects
None yet
5 participants
@helenvarley

helenvarley commented Mar 14, 2018

the shadow for the drag & drop avatar movement is very useful. can we also have this shadow for the resizing feature, so that you can see how big or small you are making your avatar?

& does the resizing happen as a jump, i.e. the audience see the avatar at one size and then immediately at the new size, or is it a gradual scaling, so that they see it shrinking or growing? (this would be cool - & maybe also remove the need for the shadow)

@prohrlac

This comment has been minimized.

Member

prohrlac commented Mar 14, 2018

If we had a smooth scaling animation there'd be no need for the ghosting and no jump for audiences.

Which would be better?

@prohrlac prohrlac changed the title from avatar resizing questions to Avatar Resizing Animation Mar 14, 2018

@prohrlac prohrlac changed the title from Avatar Resizing Animation to Avatar Resizing Effect Mar 14, 2018

@helenvarley

This comment has been minimized.

helenvarley commented Mar 14, 2018

i would say smooth scaling; there might be times when you want your avatar to suddenly be bigger or smaller, but that should be achieveable with a fast scale ... what do you think, @vickis ?

@thongteav

This comment has been minimized.

Contributor

thongteav commented Mar 15, 2018

We could have a smooth scaling on this issue. And a fast scale on another issue.

@prohrlac

This comment has been minimized.

Member

prohrlac commented Mar 15, 2018

Sure - by 'which would be better' I'm really looking for 'which should be done first'

@vickis

This comment has been minimized.

vickis commented Mar 15, 2018

@prohrlac prohrlac changed the title from Avatar Resizing Effect to Visibile Avatar Resizing Mar 15, 2018

@prohrlac

This comment has been minimized.

Member

prohrlac commented Mar 15, 2018

This issue asks that:

  • The resizing of avatars happen in real-time
  • The resizing is visible to audience and other players
  • The resizing appears as a 'shrink and grow' type effect

@prohrlac prohrlac changed the title from Visibile Avatar Resizing to Avatar Shrink-and-Grow Mar 15, 2018

@charlie0605

This comment has been minimized.

Contributor

charlie0605 commented Apr 5, 2018

resize-avatar
@rohrlach @helenvarley @vickis
Does something like this look right?

@vickis

This comment has been minimized.

vickis commented Apr 5, 2018

@prohrlac

This comment has been minimized.

Member

prohrlac commented Apr 5, 2018

Nice work @charlie0605 - That's exactly what I had in mind.

@helenvarley

This comment has been minimized.

helenvarley commented Apr 5, 2018

lovely! :)

@prohrlac prohrlac added this to the R6-2018 milestone Apr 6, 2018

prohrlac pushed a commit that referenced this issue Apr 7, 2018

Issue #304 (#321)
* Avatar are allowed to be resized smoothly and can be by the other player or audiance immediately

* Adjust spacing

* Changed variable name

@prohrlac prohrlac assigned helenvarley and vickis and unassigned charlie0605 Apr 7, 2018

@prohrlac prohrlac modified the milestones: R6-2018, R5-2018 Apr 8, 2018

@prohrlac

This comment has been minimized.

Member

prohrlac commented Apr 8, 2018

Moving this to R5-2018 - I merged this by mistake, good thing it actually works 😄

@prohrlac prohrlac closed this Apr 8, 2018

@vickis

This comment has been minimized.

vickis commented Apr 8, 2018

@helenvarley

This comment has been minimized.

helenvarley commented Apr 8, 2018

cool 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment