New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Cursor to Reflect Controls #322

Closed
prohrlac opened this Issue Apr 10, 2018 · 8 comments

Comments

Projects
None yet
5 participants
@prohrlac
Member

prohrlac commented Apr 10, 2018

The cursor should change depending on the focused toolbox tab. For example, when controlling an avatar - it should be a hand. A pencil when drawing etc.

@alexanderglenn

This comment has been minimized.

Contributor

alexanderglenn commented Apr 11, 2018

Just to clarify; When the drawing tab is focused, then the cursor should change to a pencil when over the canvas?

@helenvarley

This comment has been minimized.

helenvarley commented Apr 11, 2018

nice idea! that would help you to remember which palette you're in 👍

@alexanderglenn alexanderglenn self-assigned this Apr 16, 2018

@alexanderglenn

This comment has been minimized.

Contributor

alexanderglenn commented Apr 16, 2018

I have set custom icons when the drawing tab is selected and the user hovers the cursor over the canvas. The cursor changes to a pencil icon. The same happens when the avatar tabs is selected; the cursor changes to a hand icon.
Should the cursor change when the audio and backdrop tabs are selected?

@alexanderglenn

This comment has been minimized.

Contributor

alexanderglenn commented Apr 16, 2018

Which icons and at what sizes do you want to be used? The pencil and hand icons I have currently are from http://www.iconarchive.com/show/pretty-office-10-icons-by-custom-icon-design/Pencil-icon.html
It looks like the icons are free to use.

@thongteav

This comment has been minimized.

Contributor

thongteav commented Apr 16, 2018

Or something more simple like:
image
Pencil Icon

Although these icons are free, we still need to give credit to the artist. Do you know how it's usually been done? @rohrlach I usually work with just an image in a paragraph and put the credit below the image. But I'm not sure how it's done for a cursor.

@helenvarley

This comment has been minimized.

helenvarley commented Apr 18, 2018

hi team, please do NOT use any fancy icons for the cursor. it's a good idea to have a small change e.g. to a pencil as a reminder to the player that the action will be different. but something like http://www.iconarchive.com/show/pretty-office-10-icons-by-custom-icon-design/Pencil-icon.html is actually going to add distraction to the stage for the player, rather than be helpful.

when you are in the audio or backdrop palette, you should still be able to move your avatar on the stage, so the function of the cursor over the stage area does not change. therefore there is no need for a different icon. the only time it changes is with the drawing palette.

@vickis

This comment has been minimized.

vickis commented Apr 19, 2018

prohrlac pushed a commit that referenced this issue May 16, 2018

Issue #322 (#334)
* Added cursor changes for each tab in the toolbox
The cursor will change when the user hovers over the canvas.

* Added pencil icon for drawing and hand icon for avatar
Icons from http://icons.iconarchive.com

* Changed drawing pencil to down a 24x24 image
Changed the avatar cursor to 24x24 'hand' image

* Changed mouse icon to simpler monochrome image.
Changed avatar cursor to the 'grab' icon availalble in css.

* Removed css cursor code that was added
in the previous commits.

* Added fallback grab icons for Chrome and
Firefox. Fallback crosshair added for the drawing
tab.

* Removed 2 uneeded PNG files.

* .cur file added for use in ms Edge.
Pencil png image decreased to 16x16 png image.

* Only .cur pencil cursor icon needed.
.png option removed.

@prohrlac prohrlac assigned helenvarley and vickis and unassigned alexanderglenn May 16, 2018

@prohrlac prohrlac added this to the R7-2018 milestone May 16, 2018

@helenvarley

This comment has been minimized.

helenvarley commented May 17, 2018

great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment