Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Issue#271 rework #338
requested review from
May 1, 2018
Tested using Chrome.
Placed two avatars (man1 and man2) on Stage1. Both appeared as normal. Using the back button to go to Stage2, the two avatars did not appear on Stage2.
Also, I doing the same process and changed between Stage1 and Stage2 by changing the url. The two avatars only stayed on Stage1 and were not present on Stage2.
@alexanderglenn your not testing what this PR is required to pass, this PR is fixing the issue when player opens two tabs at once, first tab is stage1 and contains only one avatar1, second tab is stage2 containing 2 avatars, avatar1 and avatar2. When the player is on the first tab and puts avatar1 down and then goes to second tab, then puts avatar2 down. When the player goes back to the first tab both avatar will show even though avatar2 is not assigned to the first stage(first tab). Please refer to Helens last comment on this issue.
Opening stage1 and stage2 in two tabs:
- Stage1 has just boy avatar assigned and placed on it
- Went on stage2 and no avatar is placed on the stage (true)
- Then placed girl avatar on stage2, girl avatar shouldn't show up on stage1 (true)
- Went through the procedure Helen did for qa, the bug seems to be gone. The stages on different tabs should not be conflicting each other now.