New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#271 rework #338

Merged
merged 6 commits into from May 16, 2018

Conversation

@charlie0605
Contributor

charlie0605 commented May 1, 2018

Fix duplication issue when accessing two stage at the same time

271

@helenvarley are those steps you did to get the duplication to happen?

@charlie0605 charlie0605 self-assigned this May 1, 2018

@prohrlac prohrlac added this to the R7-2018 milestone May 7, 2018

@thongteav

Code is fine.
Testing carried out: (Firefox)

  • Stage1: boy
  • Stage2: girl, boy
  • Place boy onto stage1, shows up in stage1 and not stage2
  • Place girl onto stage2, shows up only in stage2, not stage1
  • Place boy onto stage2, doesn't affect boy in stage1 and shows up on stage2
    image
    image

@thongteav thongteav requested a review from prohrlac May 7, 2018

@alexanderglenn

Tested using Chrome.

Placed two avatars (man1 and man2) on Stage1. Both appeared as normal. Using the back button to go to Stage2, the two avatars did not appear on Stage2.

Also, I doing the same process and changed between Stage1 and Stage2 by changing the url. The two avatars only stayed on Stage1 and were not present on Stage2.

stage1

@charlie0605

This comment has been minimized.

Contributor

charlie0605 commented May 8, 2018

@alexanderglenn your not testing what this PR is required to pass, this PR is fixing the issue when player opens two tabs at once, first tab is stage1 and contains only one avatar1, second tab is stage2 containing 2 avatars, avatar1 and avatar2. When the player is on the first tab and puts avatar1 down and then goes to second tab, then puts avatar2 down. When the player goes back to the first tab both avatar will show even though avatar2 is not assigned to the first stage(first tab). Please refer to Helens last comment on this issue.

Testing process is flawed

@prohrlac

This comment has been minimized.

Member

prohrlac commented May 9, 2018

@thongteav can you please review again too?

Paul Rohrlach added some commits May 10, 2018

Paul Rohrlach
Paul Rohrlach
Paul Rohrlach
Paul Rohrlach

@thongteav thongteav self-requested a review May 15, 2018

@thongteav

thongteav approved these changes May 15, 2018 edited

Opening stage1 and stage2 in two tabs:

  • Stage1 has just boy avatar assigned and placed on it
    image
  • Went on stage2 and no avatar is placed on the stage (true)
    image
  • Then placed girl avatar on stage2, girl avatar shouldn't show up on stage1 (true)
    image
    image
  • Went through the procedure Helen did for qa, the bug seems to be gone. The stages on different tabs should not be conflicting each other now.
@thongteav

This comment has been minimized.

Contributor

thongteav commented May 15, 2018

@rohrlach I've done the review on the new bug described by Helen.

Paul Rohrlach
@prohrlac

Assuming reviewers have confirmed that this addresses the issue.

@prohrlac prohrlac merged commit 7a810e3 into develop May 16, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@prohrlac prohrlac deleted the Issue#271 branch May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment