fix(mcp): make UPSUN_API_TOKEN env var optional#34
Merged
Conversation
The .mcp.json header used ${UPSUN_API_TOKEN} which Claude Code treats as
a required env var, so installing the plugin without setting the token
fails with "Missing environment variables: UPSUN_API_TOKEN" even though
the MCP server authenticates via OAuth by default.
Switch to the ${UPSUN_API_TOKEN:-} shell-style default so the header is
sent empty when the var is unset, and OAuth handles auth as documented.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Upsun MCP server plugin configuration so installation doesn’t fail when UPSUN_API_TOKEN is not set, aligning the default behavior with the documented OAuth-based auth flow.
Changes:
- Updates the MCP header interpolation from
${UPSUN_API_TOKEN}to${UPSUN_API_TOKEN:-}to avoid requiring the env var at install time.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugins/upsun/.mcp.jsonreferenced${UPSUN_API_TOKEN}, which Claude Code validates as a required env var. Installing the plugin without setting the token fails withMissing environment variables: UPSUN_API_TOKEN, even though the MCP server (mcp.upsun.com/mcp) authenticates via OAuth by default and the README documents OAuth as the default flow.${UPSUN_API_TOKEN:-}(shell-style empty default). When the var is unset the header is sent empty and the OAuth flow takes over via the server'swww-authenticate: Bearerchallenge. Users who do set the env var continue to get header-based auth.🤖 Generated with Claude Code