Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporting of Abstract Classes #190

Closed
jayqi opened this issue Feb 23, 2019 · 2 comments · Fixed by #198
Closed

Exporting of Abstract Classes #190

jayqi opened this issue Feb 23, 2019 · 2 comments · Fixed by #198
Labels
question

Comments

@jayqi
Copy link
Collaborator

jayqi commented Feb 23, 2019

Currently, AbstractGraphReporter and AbstractPackageReporter are exported and available to users.

Why we would want to export: we expect users to extend them and define their own custom reporters

Why we would not want to export: they don't work as-is and create unneeded public interfaces for pkgnet

I don't expect users to create custom reporters, so my vote is to stop exporting them.

@jameslamb @bburns632
@jayqi jayqi added the question label Feb 23, 2019
@jameslamb
Copy link
Collaborator

I agree, let's bring them back inside

@bburns632
Copy link
Collaborator

bburns632 commented Feb 25, 2019 via email

@jayqi jayqi mentioned this issue Mar 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Roxygen documentation rewrite jayqi/pkgnet
3 participants
@jayqi @jameslamb @bburns632