Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made testing strategy portable (fixes #121) #139

Merged
merged 1 commit into from Nov 27, 2018

Conversation

@jameslamb
Copy link
Member

@jameslamb jameslamb commented Nov 26, 2018

I tried this on a Windows laptop tonight and confirmed it works. I believe where is a core part of Windows and should be as ubiquitous in that world as which is in Unix-alike distributions.

Fixes #121, removing the last technical barrier to our next release. Now it's just up to us to address the other functional things called out in the milestone.

@jameslamb jameslamb requested review from jayqi and bburns632 Nov 26, 2018
@jayqi
Copy link
Collaborator

@jayqi jayqi commented Nov 27, 2018

Apparently this won't work on Windows XP or earlier: https://stackoverflow.com/a/304447

Don't know if that matters. Microsoft stopped supporting Windows XP in 2014.

@jayqi
jayqi approved these changes Nov 27, 2018
@jayqi jayqi merged commit d1e974d into uptake:master Nov 27, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jameslamb
Copy link
Member Author

@jameslamb jameslamb commented Nov 27, 2018

WOW that's nuts. Uhhhh yeah honestly I just want it to work on Windows 8 and Windows 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.