Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upmade testing strategy portable (fixes #121) #139
Merged
Conversation
|
Apparently this won't work on Windows XP or earlier: https://stackoverflow.com/a/304447 Don't know if that matters. Microsoft stopped supporting Windows XP in 2014. |
|
WOW that's nuts. Uhhhh yeah honestly I just want it to work on Windows 8 and Windows 10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I tried this on a Windows laptop tonight and confirmed it works. I believe
whereis a core part of Windows and should be as ubiquitous in that world aswhichis in Unix-alike distributions.Fixes #121, removing the last technical barrier to our next release. Now it's just up to us to address the other functional things called out in the milestone.