Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop knitr note on CRAN #168

Merged
merged 3 commits into from Jan 24, 2019
Merged

Conversation

@bburns632
Copy link
Member

@bburns632 bburns632 commented Jan 24, 2019

CRAN checks often add this note:

checking dependencies in R code ... NOTE
Namespace in Imports field not imported from: ‘knitr’
  All declared Imports should be used.

This addition, which is legitimately used within the vignette eventually, should stop these messages.

It's a minor issue.

@bburns632 bburns632 requested a review from jameslamb Jan 24, 2019
@codecov-io
Copy link

@codecov-io codecov-io commented Jan 24, 2019

Codecov Report

Merging #168 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   84.69%   84.69%           
=======================================
  Files          10       10           
  Lines         915      915           
=======================================
  Hits          775      775           
  Misses        140      140
Impacted Files Coverage Δ
R/CreatePackageReport.R 98.24% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ca204...e8279a2. Read the comment docs.

@jameslamb
Copy link
Member

@jameslamb jameslamb commented Jan 24, 2019

This one is so weird! I asked about this in #119 and then it mysteriously disappeared

Copy link
Member

@jameslamb jameslamb left a comment

I did double-check the logs on Travis (I thought there was a chance we'd get like a 'opt_chunks imported but not used' thing) and looks good! 0/0/0

good fix, Brian

@jameslamb jameslamb merged commit 4850fc7 into uptake:master Jan 24, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.