Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemoved closeAllConnections from tests (fixes #135) #136
Conversation
|
lgtm |
|
I had to add |
|
submitted 0.3.1 to CRAN. We should hear back tomorrow |
|
oh I know why CRAN failed on my submission! I forgot we moved the test data out to a shared folder. I'll update |
|
The build failure should be fixed when we merge #138 and rebase this (I'll do that soon). Couple things I had to fix that are unrelated to this and just related to the fact that Travis has changed under our feet in the last couple months |
Co-Authored-By: jameslamb <jaylamb20@gmail.com>
|
@austin3dickey I updated |
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 8 8
Lines 608 608
=======================================
Hits 579 579
Misses 29 29Continue to review full report at Codecov.
|
|
looks great! |
This should get CRAN off our backs. If you approve I'll cut a release and push it, but let's keep the PR open until we get accepted.