changed strategy for dropping duplicates (fixes #137) #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
don't merge this yet. If CRAN rejects us again on #136 , let's just get this into the next submission. If not, then I'll bump the version on here to 0.3.2 |
ngparas
approved these changes
Jan 30, 2019
jameslamb
force-pushed
the
bugfix/parsing
branch
from
3b2ce82
to
22f129f
Compare
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 8 8
Lines 608 608
=======================================
Hits 579 579
Misses 29 29Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #137 . To be honest, we should have been unique-ing by
_idanyway.I feel ok about this change because you can't actually avoid
_idbeing a part of each hit (AFAIK), even if you do the"source": {"include"trick.