Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Elasticsearch 6 #64

Merged
merged 1 commit into from May 21, 2018
Merged

Conversation

@jameslamb
Copy link
Member

@jameslamb jameslamb commented May 20, 2018

This PR adds support for Elasticsearch 6.x!!! This has been long overdue (Elasticsearch 6.0.0 came out in 7 months ago)...sorry for the delay.

The most relevant change (for this package) in ES 6.x was the strict enforcement of content type on HTTP requests. TL;DR previously ES just figured it out automagically for you, which made debugging kind of hard and was also a security risk. ES6 is now more verbose and will break more often when you don't tell the service what content-type is being exchanged in requests.

For more, see this blog post from Elastic's engineering team on the issue: https://www.elastic.co/blog/strict-content-type-checking-for-elasticsearch-rest-requests.

addresses #43

@jameslamb jameslamb requested review from ngparas and austin3dickey May 20, 2018
@jameslamb jameslamb force-pushed the jameslamb:feature/es6 branch from 404366f to 11f01ee May 21, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented May 21, 2018

Codecov Report

Merging #64 into master will decrease coverage by 2.59%.
The diff coverage is 30.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #64     +/-   ##
=========================================
- Coverage   72.11%   69.52%   -2.6%     
=========================================
  Files           3        3             
  Lines         538      502     -36     
=========================================
- Hits          388      349     -39     
- Misses        150      153      +3
Impacted Files Coverage Δ
R/elasticsearch_eda_funs.R 41.86% <19.04%> (-1.52%) ⬇️
R/elasticsearch_parsers.R 74.93% <50%> (-2.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18fef75...a5daff9. Read the comment docs.

@jameslamb jameslamb force-pushed the jameslamb:feature/es6 branch from 11f01ee to 668ebdd May 21, 2018
James Lamb
@jameslamb jameslamb force-pushed the jameslamb:feature/es6 branch from 668ebdd to a5daff9 May 21, 2018
@jameslamb
Copy link
Member Author

@jameslamb jameslamb commented May 21, 2018

ayyy this worked!

image

Copy link
Member

@austin3dickey austin3dickey left a comment

Nice

@jameslamb
Copy link
Member Author

@jameslamb jameslamb commented May 21, 2018

@austin3dickey thanks for reviewing

@jameslamb jameslamb merged commit 104c151 into uptake:master May 21, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jameslamb jameslamb deleted the jameslamb:feature/es6 branch Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.