Skip to content
This repository was archived by the owner on Jan 27, 2025. It is now read-only.
This repository was archived by the owner on Jan 27, 2025. It is now read-only.

A couple questions on usage of this library #24

@rvanheest

Description

@rvanheest

Hi, thanks for creating this great and nice looking component! I've got a couple of questions before deciding whether we can use this in our application.

  1. Currently this library has peerDependencies on React v0.14 and v15. Are there any plans to upgrade to React v16, which is the current version (and higher, as they are released in the future)?
  2. The icons used for folders, files, etc. are based on an old version of FontAwesome (v4). Are there plans to upgrade to the newer version (v5)?
  3. We would like to have our own custom columns in the table, which would include renaming the headers as well as displaying some dropdown fields in the 'file rows'.
    • I saw you had a great many hooks to customize the behavior of this library. However, I was not yet able to find hooks that would support renaming headers, adding columns, etc. Am I missing something?
    • One option I found was to use the headerRenderer prop and write a custom Header component, however, this would copy the whole TableHeader component in your implementation and rename some values. Similar for fileRenderer, of course. Is this the intended way of customizing the table? It doesn't seem particularly DRY.
    • I tried the above approach of copying and customizing the Header component, but once I add the DropTarget to the component, it doesn't show up anymore. Any clue as to why that is the case? Could this be the case because your library is on v2.x of react-dnd and react-dnd-html5-backend, while our's is on v5.x? If so, are there plans to upgrade?
  4. I wasn't able to find any documentation except for the live demo. Is there more documentation to be found? Until now I've tried to piece together the 'documentation' from reading the code itself.
  5. We're using TypeScript in our project, so it would really help us out if there were some type definitions available. Do you have any plans for adding those in the future?

We would really like the component, but these are some of the problems we encountered with it so far. In general it would probably already help a lot if the dependencies could be upgraded. Usually I would try to contribute something here, but I'm not yet sure how much time I'll have for that in the upcoming months.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions