send file/describe/test test command params instead of filter #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
==========================================
+ Coverage 82.77% 82.97% +0.20%
==========================================
Files 16 17 +1
Lines 418 423 +5
Branches 96 100 +4
==========================================
+ Hits 346 351 +5
Misses 72 72
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fdodino
approved these changes
Mar 24, 2024
Comment on lines
+10
to
+12
| new CodeLens( | ||
| new Range(new Position(0, 0), new Position(2, 1)), | ||
| { |
Comment on lines
+4
to
+14
| describe('string utils', () => { | ||
| describe('removeQuotes', () => { | ||
| it('should remove quotes from string', () => { | ||
| expect(removeQuotes('"hello"')).toEqual('hello') | ||
| }) | ||
|
|
||
| it('should not remove quotes from string if not at the beginning and end', () => { | ||
| expect(removeQuotes('he"llo')).toEqual('he"llo') | ||
| }) | ||
| }) | ||
| }) |
Merged
PalumboN
approved these changes
Mar 28, 2024
| () => runTests(testFQN), | ||
| ` test ${separator}${expectedCommand}${separator} --skipValidations -p ${expectedPathByShell( | ||
| () => runTest(testArgs), | ||
| ` test ${expectedCommand.replace(new RegExp(SEP, 'g'), separator)} --skipValidations -p ${expectedPathByShell( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #156
Aunque desde el LSP este PR ya funciona para que al usuario final le funcione bien se deberia mergear este pr de cli: uqbar-project/wollok-ts-cli#141