Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated airship and rtds names, added .github #9

Merged
merged 4 commits into from Nov 18, 2019
Merged

Updated airship and rtds names, added .github #9

merged 4 commits into from Nov 18, 2019

Conversation

@Jahdeh
Copy link
Contributor

Jahdeh commented Nov 15, 2019

Ticket: https://urbanairship.atlassian.net/browse/LIBS-160

I mainly just added a .github file (with contribution stuff), and Updated Connect and Urban Airship to Real Time Data Streaming and Airship respectively.

To test:
Make sure nodejs is installed (brew install node).

  1. Clone this repo and switch to the pr-updates branch.
  2. Go one step up out of the repo and make a new folder and name it whatever you like (mine was named node-connect-test) and go into it
  3. Run npm init -y
  4. Create a file called index.js
  5. Copy and paste this code into it:
const connect = require('urban-airship-connect')

const connectStream = connect('ISex_TTJRuarzs9-o_Gkhg', '<TOKEN PLACEHOLER>)

connectStream.on('data', function (data) {
    // will be called with each event
    console.log(data);
})

connectStream.write({start: 'LATEST'})
  1. Slack me for the token.
  2. In the root of the project directory run npm install ../node-connect-client
  3. Run node index.js
  4. Send a notification from goat and see if stuff pops up in the stream!

Let me know if you have any questions!
Thanks!

@Jahdeh Jahdeh requested a review from jarofghosts Nov 15, 2019
Copy link

agoodman42 left a comment

Looks good save that missing r 🤓

README.md Outdated Show resolved Hide resolved
@sarahdactyl71 sarahdactyl71 self-requested a review Nov 15, 2019
@sarahdactyl71

This comment has been minimized.

Copy link

sarahdactyl71 commented Nov 15, 2019

IT'S ALIVE!

Screen Shot 2019-11-15 at 1 31 44 PM

Copy link

sarahdactyl71 left a comment

Tested it out, thanks for the set up instructions! LGTM good work!

Copy link
Member

jarofghosts left a comment

minor change requested in the PR template file, but otherwise looks great! 👍

- [ ] If these changes added new functionality, I tested them against the live API with real auth
- [ ] I wrote tests covering these changes

* I've tested for Ruby versions:

This comment has been minimized.

Copy link
@jarofghosts

jarofghosts Nov 15, 2019

Member

this should probably be "node versions" instead (with more applicable versions)

This comment has been minimized.

Copy link
@Jahdeh

Jahdeh Nov 15, 2019

Author Contributor

Oops! Good catch! Thank you!

This comment has been minimized.

Copy link
@Jahdeh

Jahdeh Nov 18, 2019

Author Contributor

Changed to Node and added latest LTS node version! Thanks!

Copy link

agoodman42 left a comment

LGTM

@Jahdeh Jahdeh merged commit fa19d96 into master Nov 18, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Jahdeh Jahdeh deleted the pr-updates branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.