Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add test to boot fakezod with -x and check return code #168

Open
2 tasks
eamsden opened this issue Dec 8, 2023 · 4 comments
Open
2 tasks

CI: add test to boot fakezod with -x and check return code #168

eamsden opened this issue Dec 8, 2023 · 4 comments
Assignees
Labels
CI Changes are needed to CI

Comments

@eamsden
Copy link
Collaborator

eamsden commented Dec 8, 2023

CI should attempt to boot a fakezod as an integration test.

Open questions:

  • Where do we get a patched king for CI to run?
  • Should this run on
    • status branch merges?
    • All open PRs?
    • ready-for-review PRs?
    • reviewed PRs?
@eamsden eamsden added the CI Changes are needed to CI label Dec 8, 2023
@ashelkovnykov
Copy link
Contributor

Where do we get a patched king for CI to run?

This question is being resolved by @eamsden in Vere #566

I think the integration test should automatically run only on status branch merges, but there should be an on-demand test that reviewers can run / request for a given PR / branch.

@eamsden
Copy link
Collaborator Author

eamsden commented Dec 16, 2023

@urbit/runtime what do we need to do to have a prebuilt binary of vere with that functionality easily accessible to Ares CI?

@eamsden eamsden self-assigned this Dec 16, 2023
@ashelkovnykov
Copy link
Contributor

@eamsden Pull latest stable Vere release from urbit.org?

@eamsden
Copy link
Collaborator Author

eamsden commented Dec 17, 2023

@ashelkovnykov there's a couple of issues. The first is that that PR is not merged yet. The second is that Vere assumes that it will run with Vere as its serf, which is fine for normal operations, but is not fine in what we might call "yeoman" mode, where the user-invoked Vere simply loads the snapshot itself. This is done for several of the subcommands, for instance for ./urbit pack and ./urbit meld among others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Changes are needed to CI
Projects
None yet
Development

No branches or pull requests

2 participants