This repository has been archived by the owner on Aug 14, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a
bitcoin
sur
andlib
for dealing with Bitcoin RPC requests and responses.I've included a simple
/app/bitcoin-cli
that uses the lib to forward RPC call nouns to an actual node. Very bare-bones, with hard-coded URL and all... but it works!This PR is easily considered incomplete, but I'm opening it for discussion to support further development. Maybe we're fine merging this as-is though? It works, and "support additional Bitcoin RPC calls" might be a good contributor issue.
It'd be cool if we could send transactions in whatever way. I think my best bet it to talk to @loganallenc about what the deal is with the accounts/wallets and transactions interfaces.
I vaguely remember there being auras for bitcoin addresses, does anyone know what they are?
The request-tag-as-json-id pattern here feels pretty nice. We might want to consider using that for Ethereum RPC integration as well, as a default, but I haven't thought it over much yet.
Includes/depends on #1051.