Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuuly templates changes #2

Open
wants to merge 2 commits into
base: master
from

Conversation

@krismolendyke
Copy link

commented Aug 12, 2019

Based on #1, review cf97524?w=1 for clarity

What

  • Silly trailing whitespace fixes ?w=1 ftw when reviewing
  • Big Query: Modified to pass in additional dependencies so views can depend on tables they use.
  • Big Query: Modified to change DM resource names to match top-level name we define in the specification. This enables
    one deployment to have the two tables/views with the same name, but in different datasets. This is allowable by
    BigQuery, e.g., a manifest defining a table named "table" in a dataset named "dataset" would create a resource in
    that deployment named "table" - this change creates that resource as "dataset_table". Resource names for the
    datasets and tables remain the same.
  • KMS: Modified to support a single deployment containing keys w/ identical names that belong to distinct keyrings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.