Permalink
Branch: master
Find file Copy path
Fetching contributors…
Cannot retrieve contributors at this time
36 lines (25 sloc) 2.2 KB

Contributing

Hi there! We're thrilled that you'd like to contribute to this project. Your help is essential for keeping it great.

Please note that this project is released with a Contributor Code of Conduct. By participating in this project you agree to abide by its terms.

Submitting a pull request

  1. Optional: Open an issue describing your intended changes if you'd like! I'm happy to discuss any changes you'd like to see or provide feedback on a proposed design.
  2. Fork and clone the repository.
  3. Run the tests with go test ./validator (or by installing the Google Cloud Build GitHub App on your fork). Verify they work, and open an issue if not.
  4. Create a new branch: git checkout -b my-branch-name
  5. Make your changes.
  6. Add tests to confirm your changes. Verify that they pass.
  7. Push to your fork and submit a pull request describing your changes and the motivation behind them.
  8. Pat your self on the back and wait for your pull request to be reviewed and merged. Have patience if it takes a minute.

Here are a few things you can do that will increase the likelihood of your pull request being accepted:

  • Follow the style guide and format your code using goimports, gofmt, or something similar.
  • Keep your change as focused as possible. If there are multiple changes you would like to make that are not dependent upon each other, consider submitting them as separate pull requests.
  • Write a good commit message.

Work in Progress pull requests are also welcome to get feedback early on, or if there is something blocked you. Please prefix the title of your PR with [WIP] if your changes are still in progress!

Resources